Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752438AbbFYPDL (ORCPT ); Thu, 25 Jun 2015 11:03:11 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:35145 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751648AbbFYPDA (ORCPT ); Thu, 25 Jun 2015 11:03:00 -0400 Date: Thu, 25 Jun 2015 16:02:55 +0100 From: Lee Jones To: Javier Martinez Canillas Cc: "linux-arm-kernel@lists.infradead.org" , Linux Kernel , "devicetree@vger.kernel.org" , kernel@stlinux.com, "linux-pm@vger.kernel.org" , Viresh Kumar , "Rafael J. Wysocki" , Ajit Pal Singh Subject: Re: [PATCH v2 7/9] ARM: multi_v7_defconfig: Enable support for PWM Regulators Message-ID: <20150625150255.GE23990@x1> References: <1435154348-28840-1-git-send-email-lee.jones@linaro.org> <1435154348-28840-8-git-send-email-lee.jones@linaro.org> <20150625084204.GW15013@x1> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1732 Lines: 44 On Thu, 25 Jun 2015, Javier Martinez Canillas wrote: > On Thu, Jun 25, 2015 at 10:42 AM, Lee Jones wrote: > > On Wed, 24 Jun 2015, Javier Martinez Canillas wrote: > > [...] > > >> > diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig > >> > index f632af0..6666973 100644 > >> > --- a/arch/arm/configs/multi_v7_defconfig > >> > +++ b/arch/arm/configs/multi_v7_defconfig > >> > @@ -365,6 +365,7 @@ CONFIG_REGULATOR_MAX8907=y > >> > CONFIG_REGULATOR_MAX8973=y > >> > CONFIG_REGULATOR_MAX77686=y > >> > CONFIG_REGULATOR_PALMAS=y > >> > +CONFIG_REGULATOR_PWM=y > >> > >> The current policy is to build as much as possible as a module in > >> multi_v7_defconfig. Since this is a tristate Kconfig symbol, could you > >> please change it to =m ? > > > > I would prefer that it stays built-in. > > > > Ok, I've no strong opinion on this. I was just mentioning what arm-soc > maintainers prefer nowadays. > > May I ask what's the rationale for leaving this option built-in? My view is that multi_v7 is used for prototyping, testing and to ensure all of the vendors are playing nice together. Hopefully vendors aren't actually releasing kernels built with this defconfig! During testing/prototyping time; installing and messing around with modules is an over-head I can do without. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/