Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752340AbbFYPKF (ORCPT ); Thu, 25 Jun 2015 11:10:05 -0400 Received: from foss.arm.com ([217.140.101.70]:57442 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751782AbbFYPJ4 (ORCPT ); Thu, 25 Jun 2015 11:09:56 -0400 Date: Thu, 25 Jun 2015 16:09:38 +0100 From: Mark Rutland To: Y Vo Cc: "linus.walleij@linaro.org" , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "arm@kernel.org" , "linux-kernel@vger.kernel.org" , Phong Vo , Toan Le , "patches@apm.com" , Loc Ho Subject: Re: [PATCH v0] arm64: dts: Add poweroff button device node for APM X-Gene platform Message-ID: <20150625150938.GB6844@leverpostej> References: <1434505312-27977-1-git-send-email-yvo@apm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1434505312-27977-1-git-send-email-yvo@apm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1518 Lines: 52 On Wed, Jun 17, 2015 at 02:41:52AM +0100, Y Vo wrote: > This patch adds poweroff button device node to support poweroff feature > on APM X-Gene Mustang platform. > > Signed-off-by: Y Vo > --- > arch/arm64/boot/dts/apm/apm-mustang.dts | 11 +++++++++++ > 1 files changed, 11 insertions(+), 0 deletions(-) > > diff --git a/arch/arm64/boot/dts/apm/apm-mustang.dts b/arch/arm64/boot/dts/apm/apm-mustang.dts > index 83578e7..67979c8 100644 > --- a/arch/arm64/boot/dts/apm/apm-mustang.dts > +++ b/arch/arm64/boot/dts/apm/apm-mustang.dts > @@ -23,6 +23,17 @@ > device_type = "memory"; > reg = < 0x1 0x00000000 0x0 0x80000000 >; /* Updated by bootloader */ > }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + apm_ctrl_name = "Power Button"; Huh? Undocumented, unused, and doesn't follwo the "vendor,property" naming scheme... Mark. > + btn3 { > + label = "EXT_PWR"; > + linux,code = <116>; > + linux,input-type = <0x1>; /* EV_KEY */ > + interrupts = <0x0 0x2d 0x1>; > + }; > + }; > }; > > &pcie0clk { > -- > 1.7.1 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/