Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752104AbbFYPSk (ORCPT ); Thu, 25 Jun 2015 11:18:40 -0400 Received: from foss.arm.com ([217.140.101.70]:57468 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751463AbbFYPST (ORCPT ); Thu, 25 Jun 2015 11:18:19 -0400 Date: Thu, 25 Jun 2015 16:18:00 +0100 From: Mark Rutland To: Anurag Kumar Vulisha Cc: "wsa@the-dreams.de" , "robh+dt@kernel.org" , Pawel Moll , "ijc+devicetree@hellion.org.uk" , "galak@codeaurora.org" , "michal.simek@xilinx.com" , "soren.brinkmann@xilinx.com" , "linux-i2c@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "punnaia@xilinx.com" , "harinik@xilinx.com" , "anirudh@xilinx.com" , "svemula@xilinx.com" , Anurag Kumar Vulisha Subject: Re: [PATCH] i2c: removed work arounds in i2c driver for Zynq Ultrascale+ MPSoC Message-ID: <20150625151800.GC6844@leverpostej> References: <1434644382-11905-1-git-send-email-anuragku@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1434644382-11905-1-git-send-email-anuragku@xilinx.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1621 Lines: 41 On Thu, Jun 18, 2015 at 05:19:42PM +0100, Anurag Kumar Vulisha wrote: > Removed the workarounds present in the cadence i2c driver for > Zynq Ultrascale+ MPSoC I guess this means that cdns,i2c-r1p10 had quirks fixed in cdns,i2c-r1p14? It would be helpful to be a bit more explicit in the commit message. > > Signed-off-by: Anurag Kumar Vulisha > --- > .../devicetree/bindings/i2c/i2c-cadence.txt | 2 +- > drivers/i2c/busses/i2c-cadence.c | 67 ++++++++++++++++--- > 2 files changed, 57 insertions(+), 12 deletions(-) > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-cadence.txt b/Documentation/devicetree/bindings/i2c/i2c-cadence.txt > index 7cb0b56..11ef7f2 100644 > --- a/Documentation/devicetree/bindings/i2c/i2c-cadence.txt > +++ b/Documentation/devicetree/bindings/i2c/i2c-cadence.txt > @@ -2,7 +2,7 @@ Binding for the Cadence I2C controller > > Required properties: > - reg: Physical base address and size of the controller's register area. > - - compatible: Compatibility string. Must be 'cdns,i2c-r1p10'. > + - compatible: Compatibility string.Use 'cdns,i2c-r1p10' or 'cdns,i2c-r1p14' Please format this as a list. It aids legibility and expansion. e.g: - compatible: should contain one of: * "cdns,i2c-r1p10" * "cdns,i2c-r1p14" Perhaps with notes as to the differences. Thanks, Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/