Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751685AbbFYPtj (ORCPT <rfc822;w@1wt.eu>);
	Thu, 25 Jun 2015 11:49:39 -0400
Received: from mail-oi0-f48.google.com ([209.85.218.48]:34700 "EHLO
	mail-oi0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750993AbbFYPtb (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 25 Jun 2015 11:49:31 -0400
MIME-Version: 1.0
In-Reply-To: <20150625121729.GD13366@sudip-PC>
References: <CAFow2F8Vgh93P5wmvDKcLCkiO2KkXQ14M1DXLhyeD6WTcH2RHg@mail.gmail.com>
	<1435163120-3253-16-git-send-email-juston.h.li@gmail.com>
	<20150625121729.GD13366@sudip-PC>
Date: Thu, 25 Jun 2015 08:49:30 -0700
X-Google-Sender-Auth: s4npKr4quduuqFmCW2NRPRp_4_4
Message-ID: <CAFow2F_zK42gJ0UoV+GwqLrfsxB2Nqi8kaB7OB+=-APftp=FfQ@mail.gmail.com>
Subject: Re: [PATCH v3 16/19] staging: sm750fb: fix brace placement
From: Juston Li <juston.h.li@gmail.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: teddy.wang@siliconmotion.com, Greg KH <gregkh@linuxfoundation.org>,
        linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org, Dan Carpenter <dan.carpenter@oracle.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1259
Lines: 38

On Thu, Jun 25, 2015 at 5:17 AM, Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:
> On Wed, Jun 24, 2015 at 09:25:17AM -0700, Juston Li wrote:
>> Fix brace placement errors caught by checkpatch.pl
>> ERROR: that open brace { should be on the previous line
>>
>> Signed-off-by: Juston Li <juston.h.li@gmail.com>
>> ---
> <snip>
>> @@ -71,14 +66,11 @@ static void setDisplayControl(int ctrl, int dispState)
>>                       POKE32(PANEL_DISPLAY_CTRL, ulDisplayCtrlReg);
>>               }
>>
>> -     }
>>       /* Set the secondary display control */
>> -     else
>> -     {
>> +     } else {
> just a thought. The comment previously was at the beginning of the else
> block, but now it will be placed inside the if block - at the end.
> will it confuse code readers afterwards?
>
> regards
> sudip

I placed it above the else to make it consistent with the if statement with
similar comment that the else corresponds to:

/* Set the primary display control */
- if (!ctrl)+ if (!ctrl) {

Thanks
Juston
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/