Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751558AbbFYRBc (ORCPT ); Thu, 25 Jun 2015 13:01:32 -0400 Received: from mail-ob0-f169.google.com ([209.85.214.169]:35799 "EHLO mail-ob0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752502AbbFYRBS (ORCPT ); Thu, 25 Jun 2015 13:01:18 -0400 MIME-Version: 1.0 In-Reply-To: References: <1419462712-14151-1-git-send-email-walter@vanguardiasur.com.ar> <20150105092153.GJ13070@pengutronix.de> <550F8297.80809@opensource.altera.com> Date: Thu, 25 Jun 2015 14:01:17 -0300 Message-ID: Subject: Re: [PATCH v2] ARM: socfpga: dts: Add adxl34x From: Walter Lozano To: Geert Uytterhoeven Cc: Dinh Nguyen , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Steffen Trumtrar Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4330 Lines: 123 On Thu, Jun 25, 2015 at 4:28 AM, Geert Uytterhoeven wrote: > On Tue, Jun 23, 2015 at 10:20 PM, Walter Lozano > wrote: >> On Mon, Mar 23, 2015 at 11:29 PM, Walter Lozano >> wrote: >>> On Mon, Mar 23, 2015 at 12:03 AM, Dinh Nguyen >>> wrote: >>>> On 3/19/15 4:27 PM, Walter Lozano wrote: >>>>> On Mon, Mar 16, 2015 at 10:10 AM, Walter Lozano >>>>> wrote: >>>>>> On Mon, Jan 5, 2015 at 6:21 AM, Steffen Trumtrar >>>>>> wrote: >>>>>>> On Wed, Dec 24, 2014 at 08:11:52PM -0300, Walter Lozano wrote: >>>>>>>> This patch adds the DTS bindings for the adxl34x digital >>>>>>>> accelerometer. >>>>>>>> >>>>>>>> Signed-off-by: Walter Lozano >>>>>>>> --- >>>>>>>> arch/arm/boot/dts/socfpga_cyclone5_sockit.dts | 16 ++++++++++++++++ >>>>>>>> 1 file changed, 16 insertions(+) >>>>>>>> >>>>>>>> diff --git a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts >>>>>>>> index 16ea6f5..d343e03 100644 >>>>>>>> --- a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts >>>>>>>> +++ b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts >>>>>>>> @@ -60,6 +60,22 @@ >>>>>>>> rxc-skew-ps = <2000>; >>>>>>>> }; >>>>>>>> >>>>>>>> +&gpio2 { >>>>>>>> + status = "okay"; >>>>>>>> +}; >>>>>>>> + >>>>>>>> +&i2c1 { >>>>>>>> + status = "okay"; >>>>>>>> + >>>>>>>> + accel1: accelerometer@53 { >>>>>>>> + compatible = "adxl34x"; >>>> >>>> Shouldn't this be "adi,adxl34x"? At least that's what the documentation >>>> says. >>>> >>>>>>>> + reg = <0x53>; >>>>>>>> + >>>>>>>> + interrupt-parent = <&portc>; >>>>>>>> + interrupts = <3 2>; >>>>>>>> + }; >>>>>>>> +}; >>>>>>>> + >>>>>>>> &mmc0 { >>>>>>>> vmmc-supply = <®ulator_3_3v>; >>>>>>>> vqmmc-supply = <®ulator_3_3v>; >>>>>>> >>>>>>> I just gave it a short spin. I get some interrupts and the position property >>>>>>> changes, so it seems to work: >>>>>>> >>>>>>> Acked-by: Steffen Trumtrar >>>>>>> >>>>>> >>>>>> Ping? >>>>>> How should this continue? >>>>> >>>>> Any news about this patch? It has been acked by Pavel Machek and >>>>> Steffen Trumtrar a while ago. >>>>> >>>> >>>> Sorry, since I wasn't CC on the original patch and somehow my filter >>>> didn't catch it, I didn't see this patch until now. >>> >>> No problem, I know it was my fault as I trust the output of get_maintainer.pl >>> >> >> Ping? >> >> -- >> Walter Lozano, VanguardiaSur >> www.vanguardiasur.com.ar >> -- >> To unsubscribe from this list: send the line "unsubscribe devicetree" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > Now these commits are in: > - 3a38958d2477b718 ("Input: adxl34x - add OF match support") [1] > - e465bf6fc55d5ce2 ("DT: i2c: Deprecate adi,adxl34x compatible string") [2] > > you can use "adi,adxl345" (or "adi,adxl346", "adi,adxl345"). > > [1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=3a38958d2477b718d1011fb88c24c4f264ee9700 > [2] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e465bf6fc55d5ce21fb45a75c3fa613505e6be20 > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds Thanks for the information Geert. Dihn, as I can see you have apply an old version of the this patch (V1), instead of V2 which has some format corrections suggested by Steffen Trumtrar. I addition, as Geert points, the compatibility string should now be updated. How would you like to proceed? Regards -- Walter Lozano, VanguardiaSur www.vanguardiasur.com.ar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/