Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752228AbbFYRjO (ORCPT ); Thu, 25 Jun 2015 13:39:14 -0400 Received: from mx0b-0016ce01.pphosted.com ([67.231.156.153]:60886 "EHLO mx0b-0016ce01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751863AbbFYRjC (ORCPT ); Thu, 25 Jun 2015 13:39:02 -0400 Date: Thu, 25 Jun 2015 13:38:54 -0400 From: Chad Dupuis X-X-Sender: cdupuis@administrators-macbook-pro.local To: Nicholas Krause CC: , , , Subject: Re: [PATCH] bnxfc:Make the function bnx2fc_alloc_work static In-Reply-To: <1435090966-31918-1-git-send-email-xerofoify@gmail.com> Message-ID: References: <1435090966-31918-1-git-send-email-xerofoify@gmail.com> User-Agent: Alpine 2.00 (OSX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="US-ASCII" X-Originating-IP: [10.1.4.10] disclaimer: bypass X-Proofpoint-Virus-Version: vendor=nai engine=5700 definitions=7843 signatures=670598 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1402240000 definitions=main-1506250296 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1207 Lines: 34 Make sense. Acked-by: Chad Dupuis On Tue, 23 Jun 2015, Nicholas Krause wrote: > This makes the function bnx_2fc_alloc_work static now due > to this function's only caller being in this particular > function's definition/declaration file of bnx2fc_hwi.c. > > Signed-off-by: Nicholas Krause > --- > drivers/scsi/bnx2fc/bnx2fc_hwi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/bnx2fc/bnx2fc_hwi.c b/drivers/scsi/bnx2fc/bnx2fc_hwi.c > index c6688d7..15eef07 100644 > --- a/drivers/scsi/bnx2fc/bnx2fc_hwi.c > +++ b/drivers/scsi/bnx2fc/bnx2fc_hwi.c > @@ -994,7 +994,7 @@ void bnx2fc_arm_cq(struct bnx2fc_rport *tgt) > > } > > -struct bnx2fc_work *bnx2fc_alloc_work(struct bnx2fc_rport *tgt, u16 wqe) > +static struct bnx2fc_work *bnx2fc_alloc_work(struct bnx2fc_rport *tgt, u16 wqe) > { > struct bnx2fc_work *work; > work = kzalloc(sizeof(struct bnx2fc_work), GFP_ATOMIC); > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/