Message-ID: <1435254317.11808.327.camel@misato.fc.hp.com>
Subject: Re: [PATCH v2 15/17] libnvdimm: Set numa_node to NVDIMM devices
From: Toshi Kani <toshi.kani@hp.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-nvdimm@ml01.01.org, axboe@kernel.dk, boaz@plexistor.com,
        linux-kernel@vger.kernel.org, hch@lst.de, linux-acpi@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, mingo@kernel.org
Date: Thu, 25 Jun 2015 11:45:17 -0600
In-Reply-To: <20150625093738.40066.88750.stgit@dwillia2-desk3.jf.intel.com>
References: <20150625090554.40066.69562.stgit@dwillia2-desk3.jf.intel.com>
	 <20150625093738.40066.88750.stgit@dwillia2-desk3.jf.intel.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1330
Lines: 35

On Thu, 2015-06-25 at 05:37 -0400, Dan Williams wrote:
> From: Toshi Kani <toshi.kani@hp.com>
> 
> ACPI NFIT table has System Physical Address Range Structure entries that
> describe a proximity ID of each range when ACPI_NFIT_PROXIMITY_VALID is
> set in the flags.
> 
> Change acpi_nfit_register_region() to map a proximity ID to its node ID,
> and set it to a new numa_node field of nd_region_desc, which is then
> conveyed to the nd_region device.
> 
> The device core arranges for btt and namespace devices to inherit their
> node from their parent region.
> 
> Signed-off-by: Toshi Kani <toshi.kani@hp.com>
> [djbw: move set_dev_node() from region 'probe' to 'create']

Sorry, I failed to mention other issue, which led me call set_dev_node()
in probe.  nd_async_device_register() calls device_add(), which does:

        /* use parent numa_node */
        if (parent)
                set_dev_node(dev, dev_to_node(parent));

and overwrites numa_node to -1.  Since region's parent is ndbusN, we
cannot set numa_node to the parent.  So, I had to set it in probe. 

Thanks,
-Toshi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/