Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752266AbbFYRr5 (ORCPT ); Thu, 25 Jun 2015 13:47:57 -0400 Received: from mail-wg0-f52.google.com ([74.125.82.52]:36521 "EHLO mail-wg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751378AbbFYRru (ORCPT ); Thu, 25 Jun 2015 13:47:50 -0400 MIME-Version: 1.0 In-Reply-To: <1435254317.11808.327.camel@misato.fc.hp.com> References: <20150625090554.40066.69562.stgit@dwillia2-desk3.jf.intel.com> <20150625093738.40066.88750.stgit@dwillia2-desk3.jf.intel.com> <1435254317.11808.327.camel@misato.fc.hp.com> Date: Thu, 25 Jun 2015 10:47:48 -0700 Message-ID: Subject: Re: [PATCH v2 15/17] libnvdimm: Set numa_node to NVDIMM devices From: Dan Williams To: Toshi Kani Cc: "linux-nvdimm@lists.01.org" , Jens Axboe , Boaz Harrosh , "linux-kernel@vger.kernel.org" , Christoph Hellwig , Linux ACPI , linux-fsdevel , Ingo Molnar Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1423 Lines: 34 On Thu, Jun 25, 2015 at 10:45 AM, Toshi Kani wrote: > On Thu, 2015-06-25 at 05:37 -0400, Dan Williams wrote: >> From: Toshi Kani >> >> ACPI NFIT table has System Physical Address Range Structure entries that >> describe a proximity ID of each range when ACPI_NFIT_PROXIMITY_VALID is >> set in the flags. >> >> Change acpi_nfit_register_region() to map a proximity ID to its node ID, >> and set it to a new numa_node field of nd_region_desc, which is then >> conveyed to the nd_region device. >> >> The device core arranges for btt and namespace devices to inherit their >> node from their parent region. >> >> Signed-off-by: Toshi Kani >> [djbw: move set_dev_node() from region 'probe' to 'create'] > > Sorry, I failed to mention other issue, which led me call set_dev_node() > in probe. nd_async_device_register() calls device_add(), which does: > > /* use parent numa_node */ > if (parent) > set_dev_node(dev, dev_to_node(parent)); > > and overwrites numa_node to -1. Since region's parent is ndbusN, we > cannot set numa_node to the parent. So, I had to set it in probe. ah, ok. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/