Subject: Re: [PATCH] ARM: use phys_addr_t in pfn_to_kaddr()
To: Nicolas Pitre <nicolas.pitre@linaro.org>,
        Vitaly Andrianov <vitalya@ti.com>
References: <1435072386-13527-1-git-send-email-vitalya@ti.com>
 <558B0388.1040006@oracle.com>
 <alpine.LFD.2.11.1506251232050.2617@knanqh.ubzr>
Cc: linux@arm.linux.org.uk, ssantosh@kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
From: santosh shilimkar <santosh.shilimkar@oracle.com>
Organization: Oracle Corporation
Message-ID: <558C4BE6.20009@oracle.com>
Date: Thu, 25 Jun 2015 11:43:50 -0700
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.0.1
MIME-Version: 1.0
In-Reply-To: <alpine.LFD.2.11.1506251232050.2617@knanqh.ubzr>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 914
Lines: 33

On 6/25/2015 9:33 AM, Nicolas Pitre wrote:
> On Wed, 24 Jun 2015, santosh shilimkar wrote:
>
>> On 6/23/2015 8:13 AM, Vitaly Andrianov wrote:
>>> This patch fixes pfn_to_kaddr() to use phys_addr_t.  Without this,
>>> this macro is broken on LPAE systems. For physical addresses above
>>> first 4GB result of shifting pfn with PAGE_SHIFT may be truncated.
>>>
>>> Signed-off-by: Vitaly Andrianov <vitalya@ti.com>
>>> ---
>> Looks a valid fix.
>>
>> RMK, Nico, what you say ?
>
> Looks fine to me.
>
> Acked-by: Nicolas Pitre <nico@linaro.org>
>
Thanks Nico.

Vitaly,
I suggest you to drop this patch into RMK's patch system with
mine and Nico's ack.

Regards,
Santosh


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/