Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751712AbbFYUbt (ORCPT ); Thu, 25 Jun 2015 16:31:49 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:46301 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751421AbbFYUbl (ORCPT ); Thu, 25 Jun 2015 16:31:41 -0400 Date: Thu, 25 Jun 2015 23:31:15 +0300 From: Dan Carpenter To: Juston Li Cc: Sudip Mukherjee , teddy.wang@siliconmotion.com, Greg KH , linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 16/19] staging: sm750fb: fix brace placement Message-ID: <20150625203115.GN30834@mwanda> References: <1435163120-3253-16-git-send-email-juston.h.li@gmail.com> <20150625121729.GD13366@sudip-PC> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 676 Lines: 21 On Thu, Jun 25, 2015 at 08:49:30AM -0700, Juston Li wrote: > I placed it above the else to make it consistent with the if statement with > similar comment that the else corresponds to: > > /* Set the primary display control */ > - if (!ctrl)+ if (!ctrl) { Once you add the else statement, then that kind of doesn't make sense. Sudip is right. It should be: } else { /* commentary about else side */ regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/