Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752989AbbFYVlN (ORCPT ); Thu, 25 Jun 2015 17:41:13 -0400 Received: from relay1.sgi.com ([192.48.180.66]:41321 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751782AbbFYVlC (ORCPT ); Thu, 25 Jun 2015 17:41:02 -0400 X-Greylist: delayed 377 seconds by postgrey-1.27 at vger.kernel.org; Thu, 25 Jun 2015 17:41:02 EDT Date: Thu, 25 Jun 2015 16:34:43 -0500 From: Nathan Zimmer To: Mel Gorman Cc: Nathan Zimmer , Daniel J Blueman , Andrew Morton , Waiman Long , Dave Hansen , Scott Norton , Linux-MM , LKML , Steffen Persvold Subject: Re: [PATCH] mm: meminit: Finish initialisation of struct pages before basic setup Message-ID: <20150625213443.GA129272@asylum.americas.sgi.com> References: <20150513163157.GR2462@suse.de> <1431597783.26797.1@cpanel21.proisp.no> <20150624225028.GA97166@asylum.americas.sgi.com> <20150625204855.GC26927@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150625204855.GC26927@suse.de> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1057 Lines: 27 On Thu, Jun 25, 2015 at 09:48:55PM +0100, Mel Gorman wrote: > On Wed, Jun 24, 2015 at 05:50:28PM -0500, Nathan Zimmer wrote: > > My apologies for taking so long to get back to this. > > > > I think I did locate two potential sources of slowdown. > > One is the set_cpus_allowed_ptr as I have noted previously. > > However I only notice that on the very largest boxes. > > I did cobble together a patch that seems to help. > > > > If you are using kthread_create_on_node(), is it even necessary to call > set_cpus_allowed_ptr() at all? > Yup kthread_create_on_node unconditionanly calls set_cpus_allowed_ptr(task, cpu_all_mask); It does it to avoid inherting kthreadd's properties. Not being familiar with scheduling code I assumed I missed something. However it sounds like it should respect the choice. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/