Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752191AbbFYVoa (ORCPT ); Thu, 25 Jun 2015 17:44:30 -0400 Received: from relay2.sgi.com ([192.48.180.65]:45536 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751555AbbFYVoW (ORCPT ); Thu, 25 Jun 2015 17:44:22 -0400 From: Nathan Zimmer Cc: Nathan Zimmer , Andrew Morton , Nishanth Aravamudan , Tejun Heo , Lai Jiangshan , Mel Gorman , linux-kernel@vger.kernel.org Subject: [RFC] kthread_create_on_node is failing to honor the node choice Date: Thu, 25 Jun 2015 16:44:13 -0500 Message-Id: <1435268653-167841-1-git-send-email-nzimmer@sgi.com> X-Mailer: git-send-email 1.8.2.1 In-Reply-To: <20150625204855.GC26927@suse.de> References: <20150625204855.GC26927@suse.de> To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1301 Lines: 40 In kthread_create_on_node we set_cpus_allowed to cpu_all_mask regardless of what the node is requested. This seems incorrect. Signed-off-by: Nathan Zimmer Cc: Andrew Morton Cc: Nishanth Aravamudan Cc: Tejun Heo Cc: Lai Jiangshan Cc: Mel Gorman Cc: linux-kernel@vger.kernel.org --- kernel/kthread.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/kernel/kthread.c b/kernel/kthread.c index 10e489c..d885d66 100644 --- a/kernel/kthread.c +++ b/kernel/kthread.c @@ -318,7 +318,10 @@ struct task_struct *kthread_create_on_node(int (*threadfn)(void *data), * The kernel thread should not inherit these properties. */ sched_setscheduler_nocheck(task, SCHED_NORMAL, ¶m); - set_cpus_allowed_ptr(task, cpu_all_mask); + if (node == -1) + set_cpus_allowed_ptr(task, cpu_all_mask); + else + set_cpus_allowed_ptr(task, cpumask_of_node(node)); } kfree(create); return task; -- 1.8.2.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/