Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751988AbbFYXRS (ORCPT ); Thu, 25 Jun 2015 19:17:18 -0400 Received: from filtteri1.pp.htv.fi ([213.243.153.184]:51087 "EHLO filtteri1.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751557AbbFYXRG (ORCPT ); Thu, 25 Jun 2015 19:17:06 -0400 X-Greylist: delayed 354 seconds by postgrey-1.27 at vger.kernel.org; Thu, 25 Jun 2015 19:17:05 EDT Date: Fri, 26 Jun 2015 02:11:03 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: "Luis R. Rodriguez" Cc: Andrew Morton , Borislav Petkov , Ingo Molnar , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , Andy Lutomirski , Tomi Valkeinen , "Michael S. Tsirkin" , Benjamin Herrenschmidt , "linux-kernel@vger.kernel.org" , linux-fbdev , "linux-pci@vger.kernel.org" , Dave Airlie , "Luis R. Rodriguez" , Toshi Kani , Suresh Siddha , Linus Torvalds , Thomas Gleixner , Juergen Gross , Daniel Vetter , Antonino Daplas , Jean-Christophe Plagniol-Villard , Rob Clark , Mathias Krause , Andrzej Hajda , Mel Gorman , Vlastimil Babka , Davidlohr Bueso Subject: Re: [PATCH v5 1/3] video: fbdev: atyfb: clarify ioremap() base and length used Message-ID: <20150625231103.GB4362@sci.fi> Mail-Followup-To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , "Luis R. Rodriguez" , Andrew Morton , Borislav Petkov , Ingo Molnar , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , Andy Lutomirski , Tomi Valkeinen , "Michael S. Tsirkin" , Benjamin Herrenschmidt , "linux-kernel@vger.kernel.org" , linux-fbdev , "linux-pci@vger.kernel.org" , Dave Airlie , "Luis R. Rodriguez" , Toshi Kani , Suresh Siddha , Linus Torvalds , Thomas Gleixner , Juergen Gross , Daniel Vetter , Antonino Daplas , Jean-Christophe Plagniol-Villard , Rob Clark , Mathias Krause , Andrzej Hajda , Mel Gorman , Vlastimil Babka , Davidlohr Bueso References: <1435196060-27350-1-git-send-email-mcgrof@do-not-panic.com> <1435196060-27350-2-git-send-email-mcgrof@do-not-panic.com> <20150625230437.GA4362@sci.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 763 Lines: 20 On Thu, Jun 25, 2015 at 04:06:45PM -0700, Luis R. Rodriguez wrote: > On Thu, Jun 25, 2015 at 4:04 PM, Ville Syrj?l? wrote: > > it doesn't hurt too much > > since smem_len gets overwritten later in aty_init(). > > That's the idea, we set it with a default as it will be overwritten > later anyway. Maybe toss in a comment? Otherwise it's a bit dishonest and might give someone the impression that all PCI cards really have 8MB of memory. -- Ville Syrj?l? syrjala@sci.fi http://www.sci.fi/~syrjala/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/