Date: Fri, 26 Jun 2015 01:41:12 +0200
From: Oleg Nesterov <oleg@redhat.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: Andy Lutomirski <luto@amacapital.net>,
        Andrew Morton <akpm@linux-foundation.org>,
        Al Viro <viro@zeniv.linux.org.uk>, Benjamin LaHaise <bcrl@kvack.org>,
        Hugh Dickins <hughd@google.com>, Jeff Moyer <jmoyer@redhat.com>,
        Kirill Shutemov <kirill.shutemov@linux.intel.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andy Lutomirski <luto@kernel.org>,
        Pavel Emelyanov <xemul@parallels.com>
Subject: Re: [PATCH v2 1/1] mm: move ->mremap() from file_operations to
	vm_operations_struct
Message-ID: <20150625234111.GA6046@redhat.com>
References: <20150623180225.GA12882@redhat.com> <20150625204504.GB31034@redhat.com> <20150625220829.GA25673@node.dhcp.inet.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150625220829.GA25673@node.dhcp.inet.fi>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1296
Lines: 42

On 06/26, Kirill A. Shutemov wrote:
>
> > --- a/mm/mremap.c
> > +++ b/mm/mremap.c
> > @@ -276,8 +276,8 @@ static unsigned long move_vma(struct vm_area_struct *vma,
> >  				     need_rmap_locks);
> >  	if (moved_len < old_len) {
> >  		err = -ENOMEM;
> > -	} else if (vma->vm_file && vma->vm_file->f_op->mremap) {
> > -		err = vma->vm_file->f_op->mremap(vma->vm_file, new_vma);
> > +	} else if (vma->vm_ops && vma->vm_ops->mremap) {
> > +		err = vma->vm_ops->mremap(new_vma);
> >  	}
> >
> >  	if (unlikely(err)) {
>
> I'm not sure what is target tree for the patch.

I hope akpm can take this patch into -mm,

> Last hunk is not going to
> apply on Linus' tree or -next. Hm?

Yes, this depends on another fix I sent to Andrew (and you ;), as 0/1
explains the change in move_vma() textually depends on another patch I sent,

	[PATCH 1/4] mremap: don't leak new_vma if f_op->mremap() fails
	http://marc.info/?l=linux-kernel&m=143475603713622

> Otherwise, looks good.
>
> Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>

Thanks!

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/