Message-ID: <1435288631.22927.3.camel@ubuntu>
Subject: Re: [PATCH 1/2] gpio: altera: use of_mm_gpiochip_remove() to fix
 memory leak
From: Tien Hock Loh <thloh@altera.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
CC: <linux-gpio@vger.kernel.org>, Linus Walleij <linus.walleij@linaro.org>,
        Alexandre Courbot <gnurou@gmail.com>, <linux-kernel@vger.kernel.org>
Date: Thu, 25 Jun 2015 20:17:11 -0700
In-Reply-To: <1434542383-21314-1-git-send-email-yamada.masahiro@socionext.com>
References: <1434542383-21314-1-git-send-email-yamada.masahiro@socionext.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2015 03:17:16.6043
 (UTC)
X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.227];Helo=[sj-itexedge03.altera.priv.altera.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR03MB226
X-Microsoft-Exchange-Diagnostics: 1;BL2PR03MB617;2:pbSBEhNTOSF4cJ4fMUnFLQ5NtFTqe7U3Z0LC0oWD2ZqXexNhHcm2DwiUaWpKjtvV;3:66qb4yEiETpB+LiQxd92JNx4Gs3puRpEsL3yJsSoZXccNPJdjArPBXQmfIDTOW63k3yHgTPYP3rrRW4JqXFo4vphrW9PBXFK80+Y5famvkGXXDjnTI2CAO628Pwa6icxBjW/7+a+EOgIdVVp6W2zdJ1xPXBZjV6bmb1sh51sz9t+Ap7NPGof0amFpzyw7Oy+bjMJZJ87oA/KdJY9CBOudR09gZeHpi8x/vzZGKgRGLU=;23:T2PCq410/cx/zg+ZdQxcrpy1uZ7fVqdjqhn8COk2xEnfpr4gZ7o7HCbwqK0eVJV0ASjESPxkNhbf3keNcN0yYbwFO8JspVdVtqTRjFjIwQ0sm6h9CbQH+V8Ecq4gftQqJR0bMVenEI+7mAHuvItt4cpAfEQjLxNuVZxYs3U8Hhqw2wKj1+/yU8rmDsZ4LPfOY+30XAck3ybjjMUDYFt+t8XMzE07opdI0tfsDbFP7uPAS7STe5yzSb0VQ0dKpX8d
X-OriginatorOrg: altera.com
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1200
Lines: 34

Acked-by: Tien Hock Loh <thloh@altera.com>

On Wed, 2015-06-17 at 20:59 +0900, Masahiro Yamada wrote:
> This driver calls of_mm_gpiochip_add() to add a memory mapped gpio
> chip.  So, of_mm_gpiochip_remove() should be used when removing it.
> 
> The direct call of gpiochip_remove() misses unmapping the register
> and freeing the label.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
> 
>  drivers/gpio/gpio-altera.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpio/gpio-altera.c b/drivers/gpio/gpio-altera.c
> index 449fb46..c653c83 100644
> --- a/drivers/gpio/gpio-altera.c
> +++ b/drivers/gpio/gpio-altera.c
> @@ -337,7 +337,7 @@ static int altera_gpio_remove(struct platform_device *pdev)
>  {
>  	struct altera_gpio_chip *altera_gc = platform_get_drvdata(pdev);
>  
> -	gpiochip_remove(&altera_gc->mmchip.gc);
> +	of_mm_gpiochip_remove(&altera_gc->mmchip);
>  
>  	return -EIO;
>  }

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/