Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751732AbbFZDfc (ORCPT ); Thu, 25 Jun 2015 23:35:32 -0400 Received: from mx0a-0016f401.pphosted.com ([67.231.148.174]:52415 "EHLO mx0a-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750993AbbFZDfb (ORCPT ); Thu, 25 Jun 2015 23:35:31 -0400 Date: Fri, 26 Jun 2015 11:35:25 +0800 From: Yi Zhang To: Rob Herring CC: Vaibhav Hiremath , Samuel Ortiz , Lee Jones , Paul Bolle , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Qiao Zhou Subject: Re: [PATCH V2 1/2] mfd: add Marvell 88pm88x description Message-ID: <20150626033338.GA32229@yizhang> References: <1434098601-3498-1-git-send-email-yizhang@marvell.com> <1434098601-3498-2-git-send-email-yizhang@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-06-26_01:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 kscore.is_bulkscore=0 compositescore=0.960621519259808 phishscore=0 kscore.is_spamscore=0 rbsscore=0.960621519259808 recipient_to_sender_totalscore=0 spamscore=0 urlsuspectscore=0.960621519259808 adultscore=0 kscore.compositescore=0 circleOfTrustscore=0 malwarescore=0 suspectscore=0 recipient_domain_to_sender_totalscore=0 bulkscore=0 recipient_domain_to_sender_domain_totalscore=0 recipient_to_sender_domain_totalscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1502090000 definitions=main-1506260049 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2262 Lines: 59 On Tue, Jun 23, 2015 at 09:31:00AM -0500, Rob Herring wrote: > On Fri, Jun 12, 2015 at 3:43 AM, Yi Zhang wrote: > > 88pm880 and 88pm886 are two combo PMIC chips, most of the function and the > > register mapping are the same > > How do they compare to 80x/822/860 PMICs? Hi, Rob: 88pm80x/822/860 and 88pm886/88pm880 are two different series: - the register mapping is totally different, it's hard to reuse the existed code for 88pm80x - the latter is a chip which integrates the charger/fuelgauge/camera flash which doesn't exist in 88pm80x > > > > > Signed-off-by: Yi Zhang > > --- > > Documentation/devicetree/bindings/mfd/88pm88x.txt | 33 +++++++++++++++++++++++ > > 1 file changed, 33 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/mfd/88pm88x.txt > > > > diff --git a/Documentation/devicetree/bindings/mfd/88pm88x.txt b/Documentation/devicetree/bindings/mfd/88pm88x.txt > > new file mode 100644 > > index 0000000..72e741c > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mfd/88pm88x.txt > > @@ -0,0 +1,33 @@ > > +Marvell 88pm88x combo PMIC chip > > + > > +This series of chip integrates regulator, rtc, onkey, switch charger, > > +fuelgauge, gpadc and a range of I/O pins. > > + > > +88pm886 and 88pm880 are two very similar chips, most of the registers mapping > > +and functions are the same, the main difference is the latter has a separate > > +i2c slave address to cover BUCK related setting > > + > > +Required properties: > > +- compatible: one of the strings for a specific chip: > > + "marvell,88pm886" > > + "marvell,88pm880" > > +- reg: the i2c address > > +- interrupt-controller: it works as an interrupt controller managing its irqs > > +- interrupt-cells: this value is 1 > > + > > +Optional properties: > > +- marvell,88pm88x-irq-write-clear: the interrupt ack method > > The 80x/860 binding needs the same property. Please coordinate this > with Vaibhav. Thanks for your reminder, got it > > Rob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/