Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751952AbbFZEF7 (ORCPT ); Fri, 26 Jun 2015 00:05:59 -0400 Received: from mail-pd0-f174.google.com ([209.85.192.174]:36503 "EHLO mail-pd0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751568AbbFZEFw (ORCPT ); Fri, 26 Jun 2015 00:05:52 -0400 Date: Fri, 26 Jun 2015 09:35:43 +0530 From: Sudip Mukherjee To: Juston Li Cc: teddy.wang@siliconmotion.com, Greg KH , linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Dan Carpenter Subject: Re: [PATCH v3 11/19] staging: sm750fb: consistent spacing around operators Message-ID: <20150626040543.GB3050@sudip-PC> References: <1435163120-3253-11-git-send-email-juston.h.li@gmail.com> <20150625115618.GC13366@sudip-PC> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1390 Lines: 31 On Thu, Jun 25, 2015 at 09:26:00AM -0700, Juston Li wrote: > On Thu, Jun 25, 2015 at 4:56 AM, Sudip Mukherjee > wrote: > > On Wed, Jun 24, 2015 at 09:25:12AM -0700, Juston Li wrote: > > > 2) Considering that you are giving consitent space around operators, then > > i think you have missed few operators like '|','&',':' in this > > patch. > > > > These were the only instances the checkpatch.pl error came up. This patch > only fixes even spacing around a specific operator. Other operators either > have even or no spacing around them with PATCH 11/19 fixing any operators > with spacing around required. This leaves operators that checkpatch deems > spacing as optional which I left as a separate issue to be addressed of making > optional spacing of operators consistent with each other. Usually I use the checkpatch which is in linux-next. That will be the latest version. If you compare, last commit on checkpatch of staging tree was on April 16th, where as last commit in linux-next is on June 19th. And if you use this checkpatch you will see these warnings also. :) regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/