Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751952AbbFZGSP (ORCPT ); Fri, 26 Jun 2015 02:18:15 -0400 Received: from mail-vn0-f46.google.com ([209.85.216.46]:39843 "EHLO mail-vn0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751539AbbFZGSG convert rfc822-to-8bit (ORCPT ); Fri, 26 Jun 2015 02:18:06 -0400 MIME-Version: 1.0 In-Reply-To: <1435274950-17106-1-git-send-email-vlee@twopensource.com> References: <1435274950-17106-1-git-send-email-vlee@twopensource.com> From: David Drysdale Date: Fri, 26 Jun 2015 07:17:46 +0100 Message-ID: Subject: Re: [PATCH] selftests/exec: Fix build on older distros. To: Vinson Lee Cc: Shuah Khan , Andrew Morton , Geert Uytterhoeven , Michael Ellerman , Linux API , "linux-kernel@vger.kernel.org" , Vinson Lee Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1977 Lines: 55 On Fri, Jun 26, 2015 at 12:29 AM, Vinson Lee wrote: > From: Vinson Lee > > This patch fixes this build error on CentOS 5. > > execveat.c: In function ‘check_execveat_pathmax’: > execveat.c:185: error: ‘AT_EMPTY_PATH’ undeclared (first use in this function) > execveat.c:185: error: (Each undeclared identifier is reported only once > execveat.c:185: error: for each function it appears in.) > execveat.c: In function ‘run_tests’: > execveat.c:221: error: ‘O_PATH’ undeclared (first use in this function) > execveat.c:222: error: ‘O_CLOEXEC’ undeclared (first use in this function) > execveat.c:258: error: ‘AT_EMPTY_PATH’ undeclared (first use in this function) > > Cc: stable@vger.kernel.org # 3.19+ > Signed-off-by: Vinson Lee > --- > tools/testing/selftests/exec/execveat.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/tools/testing/selftests/exec/execveat.c b/tools/testing/selftests/exec/execveat.c > index 8d5d1d2..170148d 100644 > --- a/tools/testing/selftests/exec/execveat.c > +++ b/tools/testing/selftests/exec/execveat.c > @@ -20,6 +20,16 @@ > #include > #include > > +#ifndef AT_EMPTY_PATH > +# define AT_EMPTY_PATH 0x1000 > +#endif > +#ifndef O_PATH > +# define O_PATH 010000000 > +#endif > +#ifndef O_CLOEXEC > +# define O_CLOEXEC 02000000 > +#endif > + Won't those definitions affect the arch-independence of the test? (The O_* constants are sadly arch-specific: http://lxr.free-electrons.com/ident?i=O_PATH) > static char longpath[2 * PATH_MAX] = ""; > static char *envp[] = { "IN_TEST=yes", NULL, NULL }; > static char *argv[] = { "execveat", "99", NULL }; > -- > 1.8.2.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/