Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751940AbbFZI0L (ORCPT ); Fri, 26 Jun 2015 04:26:11 -0400 Received: from mail-wg0-f46.google.com ([74.125.82.46]:34424 "EHLO mail-wg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751751AbbFZI0D (ORCPT ); Fri, 26 Jun 2015 04:26:03 -0400 Message-ID: <558D0C97.2070107@plumgrid.com> Date: Fri, 26 Jun 2015 01:25:59 -0700 From: Alexei Starovoitov User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Xi Wang , linux-arm-kernel@lists.infradead.org CC: linux-kernel@vger.kernel.org, Zi Shen Lim Subject: Re: [RFC PATCH] arm64: bpf: fix endianness conversion bugs References: <1435282755-12011-1-git-send-email-xi.wang@gmail.com> In-Reply-To: <1435282755-12011-1-git-send-email-xi.wang@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 952 Lines: 27 On 6/25/15 6:39 PM, Xi Wang wrote: > Upper bits should be zeroed in endianness conversion: > > - even when there's no need to change endianness (i.e., BPF_FROM_BE > on big endian or BPF_FROM_LE on little endian); > > - after rev16. > > This patch fixes such bugs by emitting extra instructions to clear > upper bits. > > Cc: Zi Shen Lim > Cc: Alexei Starovoitov > Fixes: e54bcde3d69d ("arm64: eBPF JIT compiler") > Signed-off-by: Xi Wang Acked-by: Alexei Starovoitov > The current testsuite catches the 16-bit bugs. I'll send a separate > patch that extends test_bpf to catch the 32-bit ones. looking forward to it. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/