Message-ID: <558D11A4.5020102@plumgrid.com>
Date: Fri, 26 Jun 2015 01:47:32 -0700
From: Alexei Starovoitov <ast@plumgrid.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Wang Nan <wangnan0@huawei.com>, acme@kernel.org, brendan.d.gregg@gmail.com,
        daniel@iogearbox.net, namhyung@kernel.org,
        masami.hiramatsu.pt@hitachi.com, paulus@samba.org,
        a.p.zijlstra@chello.nl, mingo@redhat.com, jolsa@kernel.org,
        dsahern@gmail.com
CC: linux-kernel@vger.kernel.org, lizefan@huawei.com, hekuang@huawei.com,
        xiakaixu@huawei.com, pi3orama@163.com
Subject: Re: [RFC PATCH 3/3] perf tools: Support attach BPF program on uprobe
 events
References: <1435228645-116055-1-git-send-email-wangnan0@huawei.com> <1435228645-116055-4-git-send-email-wangnan0@huawei.com>
In-Reply-To: <1435228645-116055-4-git-send-email-wangnan0@huawei.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 856
Lines: 27

On 6/25/15 3:37 AM, Wang Nan wrote:
> This patch append new syntax to BPF object section name to support
> probing at uprobe event. Now we can use BPF program like this:
>
>   SEC(
>   "target:/lib64/libc.so.6\n"
>   "libcwrite=__write"
>   )
>   int libcwrite(void *ctx)
>   {
>       return 1;
>   }
>
> Where, in section name of a program, before the main config string,
> we can use 'key:value' style options. Now the only option key "target"
> is for uprobe probing.
>
> Signed-off-by: Wang Nan<wangnan0@huawei.com>

looks good.
why use ':' separator? '=' should work as well and will be more
consistent ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/