Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752483AbbFZI7y (ORCPT ); Fri, 26 Jun 2015 04:59:54 -0400 Received: from smtp.citrix.com ([66.165.176.89]:35075 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752127AbbFZI73 (ORCPT ); Fri, 26 Jun 2015 04:59:29 -0400 X-IronPort-AV: E=Sophos;i="5.13,683,1427760000"; d="scan'208";a="275857869" Message-ID: <558D1458.1000300@citrix.com> Date: Fri, 26 Jun 2015 09:59:04 +0100 From: David Vrabel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 MIME-Version: 1.0 To: Daniel Kiper , David Vrabel CC: , , Boris Ostrovsky , Subject: Re: [Xen-devel] [PATCHv1 5/8] xen/balloon: rationalize memory hotplug stats References: <1435252263-31952-1-git-send-email-david.vrabel@citrix.com> <1435252263-31952-6-git-send-email-david.vrabel@citrix.com> <20150625183836.GM14050@olila.local.net-space.pl> <20150625185445.GN14050@olila.local.net-space.pl> <20150625213113.GP14050@olila.local.net-space.pl> In-Reply-To: <20150625213113.GP14050@olila.local.net-space.pl> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-DLP: MIA2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 710 Lines: 16 On 25/06/15 22:31, Daniel Kiper wrote: > On Thu, Jun 25, 2015 at 08:54:45PM +0200, Daniel Kiper wrote: > > It looks that balloon_stats.total_pages is used only in memory hotplug case. > Please do references (and definition) to it inside #ifdef CONFIG_XEN_BALLOON_MEMORY_HOTPLUG > like it is done in balloon_stats.hotplug_pages and balloon_stats.balloon_hotplug case. I don't think the space saving here really warrants sprinkling a bunch of #ifdefs around. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/