Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752025AbbFZKQM (ORCPT ); Fri, 26 Jun 2015 06:16:12 -0400 Received: from cantor2.suse.de ([195.135.220.15]:48263 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751790AbbFZKQF (ORCPT ); Fri, 26 Jun 2015 06:16:05 -0400 Date: Fri, 26 Jun 2015 11:16:00 +0100 From: Mel Gorman To: Nathan Zimmer Cc: Daniel J Blueman , Andrew Morton , Waiman Long , Dave Hansen , Scott Norton , Linux-MM , LKML , Steffen Persvold Subject: Re: [PATCH] mm: meminit: Finish initialisation of struct pages before basic setup Message-ID: <20150626101600.GG26927@suse.de> References: <20150513163157.GR2462@suse.de> <1431597783.26797.1@cpanel21.proisp.no> <20150624225028.GA97166@asylum.americas.sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20150624225028.GA97166@asylum.americas.sgi.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1459 Lines: 36 On Wed, Jun 24, 2015 at 05:50:28PM -0500, Nathan Zimmer wrote: > From e18aa6158a60c2134b4eef93c856f3b5b250b122 Mon Sep 17 00:00:00 2001 > From: Nathan Zimmer > Date: Thu, 11 Jun 2015 10:47:39 -0500 > Subject: [RFC] Avoid the contention in set_cpus_allowed > > Noticing some scaling issues at larger box sizes (64 nodes+) I found that in some > cases we are spending significant amounts of time in set_cpus_allowed_ptr. > > My assumption is that it is getting stuck on migration. > So if we create the thread on the target node and restrict cpus before we start > the thread then we don't have to suffer migration. > > Cc: Mel Gorman > Cc: Waiman Long Cc: Dave Hansen > Cc: Scott Norton > Cc: Daniel J Blueman > Signed-off-by: Nathan Zimmer > I asked yesterday if set_cpus_allowed_ptr() was required and I made a mistake because it is. The node parameter for kthread_create_on_node() controls where it gets created but not how it is scheduled after that. Sorry for the noise. The patch makes sense to me now, lets see if it helps Daniel. -- Mel Gorman SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/