Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752023AbbFZMFG (ORCPT ); Fri, 26 Jun 2015 08:05:06 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:37343 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751801AbbFZME6 (ORCPT ); Fri, 26 Jun 2015 08:04:58 -0400 Message-ID: <558D3FDA.6000903@huawei.com> Date: Fri, 26 Jun 2015 20:04:42 +0800 From: "majun (F)" User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Marc Zyngier , Catalin Marinas , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Will Deacon , Mark Rutland , "jason@lakedaemon.net" , "tglx@linutronix.de" , "lizefan@huawei.com" , "huxinwei@huawei.com" Subject: Re: [PATCH v2 2/3] IRQ/Gic-V3: Change arm-gic-its to support the Mbigen interrupt References: <1434077399-32200-1-git-send-email-majun258@huawei.com> <1434077399-32200-3-git-send-email-majun258@huawei.com> <558CF1CD.5020200@huawei.com> <558D10E1.8040701@arm.com> <558D2937.7060408@huawei.com> <558D2C1A.3070702@arm.com> In-Reply-To: <558D2C1A.3070702@arm.com> Content-Type: text/plain; charset="gbk" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.177.236.124] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1276 Lines: 45 ?? 2015/6/26 18:40, Marc Zyngier ะด??: > > My opinion is that we need to be able to lookup the domain from the core > code without any of these hacks, and this is what I'm working on at the > moment. There is no way external code will be allowed to mess with the > internals of the ITS. > > For the time being, just expose the domain with a helper (you can match > it with the of_node). Do you mean add a fucntion in ITS likes below: struct irq_domain *get_its_domain(struct device_node *node) { struct its_node *its = NULL; list_for_each_entry(its, &its_nodes, entry) { if(its->msi_chip.of_node == node) break; } return (its)?its->domain:NULL; } How about add a '.match ' member in its_domain_ops just like: .match = get_its_domain; So, I can use the fucntion 'irq_find_host' in mbigne driver >In the long run, you should be able to look it up > directly from the domain list. > I think the domain list you said is 'irq_domain_list' which defined in Irqdomain.c static LIST_HEAD(irq_domain_list); Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/