Message-ID: <558D4639.8000102@gmail.com>
Date: Fri, 26 Jun 2015 18:01:53 +0530
From: Varka Bhadram <varkabhadram@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Shobhit Kumar <shobhit.kumar@intel.com>,
        linux-pwm <linux-pwm@vger.kernel.org>,
        intel-gfx <intel-gfx@lists.freedesktop.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        linux-gpio <linux-gpio@vger.kernel.org>
CC: Paul Bolle <pebolle@tiscali.nl>, Jani Nikula <jani.nikula@intel.com>,
        Samuel Ortiz <sameo@linux.intel.com>,
        Alexandre Courbot <gnurou@gmail.com>, David Airlie <airlied@linux.ie>,
        Povilas Staniulis <wdmonster@gmail.com>,
        Chih-Wei Huang <cwhuang@android-x86.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        Daniel Vetter <daniel.vetter@intel.com>,
        Lee Jones <lee.jones@linaro.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Paul Gortmaker <paul.gortmaker@windriver.com>, bloften80@gmail.com
Subject: Re: [v3 5/7] pwm: crc: Add Crystalcove (CRC) PWM driver
References: <1435309330-50725-1-git-send-email-shobhit.kumar@intel.com> <1435309330-50725-6-git-send-email-shobhit.kumar@intel.com>
In-Reply-To: <1435309330-50725-6-git-send-email-shobhit.kumar@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1939
Lines: 48

On 06/26/2015 02:32 PM, Shobhit Kumar wrote:
> The Crystalcove PMIC provides three PWM signals and this driver exports
> one of them on the BYT platform which is used to control backlight for
> DSI panel. This is platform device implementation of the drivers/mfd
> cell device for CRC PMIC.
>
> CC: Samuel Ortiz <sameo@linux.intel.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Alexandre Courbot <gnurou@gmail.com>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Paul Bolle <pebolle@tiscali.nl>
> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> Tested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com>
> ---
> v2: Use the existing config callback with duty_ns and period_ns(Thierry)
>
> v3: Correct the subject line (Lee jones)
>
> v4: Address comment by Thierry & Paul
>      - Commit message update and fixes for few syntax errors
>      - Add PWM_CRC in Kconfig and Makefile sorted alphabetically
>      - Use the PWM_BASE_CLK as 6000000 for better code readability
>      - Remove the redundant rule of three while calculating pwm level
>      - Use the platform_device in pwm_chip
>      - Use builin_platform_driver
>
> v5: Address comments by Varka
>      - Make the bit definition using BIT macro
>      - reorder probe and remove code to directly return from pwmchip_add/remove
>
>   drivers/pwm/Kconfig   |   7 +++
>   drivers/pwm/Makefile  |   1 +
>   drivers/pwm/pwm-crc.c | 143 ++++++++++++++++++++++++++++++++++++++++++++++++++
>   3 files changed, 151 insertions(+)
>   create mode 100644 drivers/pwm/pwm-crc.c

Reviewed-by: Varka Bhadram <varkabhadram@gmail.com>

-- 
Best regards,
Varka Bhadram.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/