Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752199AbbFZMeh (ORCPT ); Fri, 26 Jun 2015 08:34:37 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:36563 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751738AbbFZMeW (ORCPT ); Fri, 26 Jun 2015 08:34:22 -0400 From: David Dueck To: boris.brezillon@free-electrons.com Cc: mturquette@linaro.org, nicolas.ferre@atmel.com, sboyd@codeaurora.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/6] clk: at91: clk-main: fix memory leak Date: Fri, 26 Jun 2015 14:33:28 +0200 Message-Id: <1435322012-5667-2-git-send-email-davidcdueck@googlemail.com> X-Mailer: git-send-email 2.4.4 In-Reply-To: <1435322012-5667-1-git-send-email-davidcdueck@googlemail.com> References: <1435322012-5667-1-git-send-email-davidcdueck@googlemail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 941 Lines: 31 Do not leak memory if request_irq fails. Signed-off-by: David Dueck --- drivers/clk/at91/clk-main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/clk/at91/clk-main.c b/drivers/clk/at91/clk-main.c index 59fa3cc..696719e 100644 --- a/drivers/clk/at91/clk-main.c +++ b/drivers/clk/at91/clk-main.c @@ -171,8 +171,10 @@ at91_clk_register_main_osc(struct at91_pmc *pmc, irq_set_status_flags(osc->irq, IRQ_NOAUTOEN); ret = request_irq(osc->irq, clk_main_osc_irq_handler, IRQF_TRIGGER_HIGH, name, osc); - if (ret) + if (ret) { + kfree(osc); return ERR_PTR(ret); + } if (bypass) pmc_write(pmc, AT91_CKGR_MOR, -- 2.4.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/