Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752074AbbFZMeC (ORCPT ); Fri, 26 Jun 2015 08:34:02 -0400 Received: from mail-lb0-f173.google.com ([209.85.217.173]:34661 "EHLO mail-lb0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751740AbbFZMdz (ORCPT ); Fri, 26 Jun 2015 08:33:55 -0400 Subject: Re: [PATCH 1/1] usb: storage : Remove c99 style commenting To: Sunny Kumar , mdharm-usb@one-eyed-alien.net, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, linux-kernel@vger.kernel.org References: <1435299263-15919-1-git-send-email-sunny.kumar.roy@gmail.com> From: Sergei Shtylyov Message-ID: <558D46AF.2000609@cogentembedded.com> Date: Fri, 26 Jun 2015 15:33:51 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <1435299263-15919-1-git-send-email-sunny.kumar.roy@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1402 Lines: 43 Hello. On 6/26/2015 9:14 AM, Sunny Kumar wrote: > This patch fixes checkpatch.pl warning c99 style commenting. > Signed-off-by: Sunny Kumar > --- > drivers/usb/storage/sddr55.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > diff --git a/drivers/usb/storage/sddr55.c b/drivers/usb/storage/sddr55.c > index aacedef..54d0a59 100644 > --- a/drivers/usb/storage/sddr55.c > +++ b/drivers/usb/storage/sddr55.c > @@ -209,10 +209,10 @@ static int sddr55_read_data(struct us_data *us, > unsigned int len, offset; > struct scatterlist *sg; > > - // Since we only read in one block at a time, we have to create > - // a bounce buffer and move the data a piece at a time between the > - // bounce buffer and the actual transfer buffer. > - > + /* Since we only read in one block at a time, we have to create > + * a bounce buffer and move the data a piece at a time between the > + * bounce buffer and the actual transfer buffer. > + */ This style of commenting is preferred only in the networking code. The other parts of the kernel prefer this style: /* * bla * bla */ WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/