Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752419AbbFZNVh (ORCPT ); Fri, 26 Jun 2015 09:21:37 -0400 Received: from mail-lb0-f182.google.com ([209.85.217.182]:34642 "EHLO mail-lb0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751777AbbFZNVa (ORCPT ); Fri, 26 Jun 2015 09:21:30 -0400 Subject: Re: [PATCH] net: via: VIA_RHINE and VIA_VELOCITY should depend on HAS_DMA To: Geert Uytterhoeven , "David S. Miller" , Antonio Borneo References: <1435320502-4951-1-git-send-email-geert@linux-m68k.org> Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Sergei Shtylyov Message-ID: <558D51D4.9060202@cogentembedded.com> Date: Fri, 26 Jun 2015 16:21:24 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <1435320502-4951-1-git-send-email-geert@linux-m68k.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1794 Lines: 36 Hello. On 6/26/2015 3:08 PM, Geert Uytterhoeven wrote: > If NO_DMA=y: > ERROR: "dma_sync_single_for_cpu" [drivers/net/ethernet/via/via-rhine.ko] undefined! > ERROR: "dma_set_mask" [drivers/net/ethernet/via/via-rhine.ko] undefined! > ERROR: "dma_mapping_error" [drivers/net/ethernet/via/via-rhine.ko] undefined! > ERROR: "dma_map_single" [drivers/net/ethernet/via/via-rhine.ko] undefined! > ERROR: "dma_alloc_coherent" [drivers/net/ethernet/via/via-rhine.ko] undefined! > ERROR: "dma_free_coherent" [drivers/net/ethernet/via/via-rhine.ko] undefined! > ERROR: "dma_unmap_single" [drivers/net/ethernet/via/via-rhine.ko] undefined! > ERROR: "dma_map_page" [drivers/net/ethernet/via/via-velocity.ko] undefined! > ERROR: "dma_sync_single_for_cpu" [drivers/net/ethernet/via/via-velocity.ko] undefined! > ERROR: "dma_free_coherent" [drivers/net/ethernet/via/via-velocity.ko] undefined! > ERROR: "dma_unmap_single" [drivers/net/ethernet/via/via-velocity.ko] undefined! > ERROR: "dma_map_single" [drivers/net/ethernet/via/via-velocity.ko] undefined! > ERROR: "dma_alloc_coherent" [drivers/net/ethernet/via/via-velocity.ko] undefined! > Before, the symbols depended implicitly on HAS_DMA through PCI or > USE_OF. Add explicit dependencies on HAS_DMA to fix this. > Fixes: commit b7d3282a245f4428 ("net: via/Kconfig: replace USE_OF with OF_???") Fixes: b7d3282a245f ("net: via/Kconfig: replace USE_OF with OF_???") > Signed-off-by: Geert Uytterhoeven WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/