Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752353AbbFZNrV (ORCPT ); Fri, 26 Jun 2015 09:47:21 -0400 Received: from atl4mhob11.myregisteredsite.com ([209.17.115.49]:50124 "EHLO atl4mhob11.myregisteredsite.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752137AbbFZNrO (ORCPT ); Fri, 26 Jun 2015 09:47:14 -0400 X-TCPREMOTEIP: 88.159.208.100 X-Authenticated-UID: mike@milosoftware.com From: Mike Looijmans To: lars@metafoo.de Cc: Peter.Chen@freescale.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Mike Looijmans Subject: [PATCH 1/2] usb: chipidea: Reduce ULPI PHY reset pulse to datasheet spec of 1us Date: Fri, 26 Jun 2015 15:47:03 +0200 Message-Id: <1435326424-18748-1-git-send-email-mike.looijmans@topic.nl> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1242 Lines: 35 The datasheet for the 334x PHY mentions that a reset can be performed: "... by bringing the pin low for a minimum of 1 microsecond and then high." A delay of 5ms to implement that seems overly long, so reduce it to just 1us. As for the delay after reset, the datasheet only mentioned that the chip will assert the DIR output. 1ms seems like a safe time to wait for that to happen, so no change there. Signed-off-by: Mike Looijmans --- drivers/usb/chipidea/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c index e970863..c865abe 100644 --- a/drivers/usb/chipidea/core.c +++ b/drivers/usb/chipidea/core.c @@ -664,7 +664,7 @@ static int ci_hdrc_create_ulpi_phy(struct device *dev, struct ci_hdrc *ci) dev_err(dev, "Failed to request ULPI reset gpio: %d\n", ret); return ret; } - msleep(5); + udelay(1); gpio_set_value_cansleep(reset_gpio, 1); msleep(1); } -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/