Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752007AbbFZOIp (ORCPT ); Fri, 26 Jun 2015 10:08:45 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:60913 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751719AbbFZOIn (ORCPT ); Fri, 26 Jun 2015 10:08:43 -0400 Date: Fri, 26 Jun 2015 10:08:42 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Sunny Kumar cc: mdharm-usb@one-eyed-alien.net, , , , Subject: Re: [PATCH 1/1] usb: storage : Remove c99 style commenting In-Reply-To: <1435299263-15919-1-git-send-email-sunny.kumar.roy@gmail.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2434 Lines: 64 On Fri, 26 Jun 2015, Sunny Kumar wrote: > This patch fixes checkpatch.pl warning c99 style commenting. > > Signed-off-by: Sunny Kumar > --- > drivers/usb/storage/sddr55.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/usb/storage/sddr55.c b/drivers/usb/storage/sddr55.c > index aacedef..54d0a59 100644 > --- a/drivers/usb/storage/sddr55.c > +++ b/drivers/usb/storage/sddr55.c > @@ -209,10 +209,10 @@ static int sddr55_read_data(struct us_data *us, > unsigned int len, offset; > struct scatterlist *sg; > > - // Since we only read in one block at a time, we have to create > - // a bounce buffer and move the data a piece at a time between the > - // bounce buffer and the actual transfer buffer. > - > + /* Since we only read in one block at a time, we have to create > + * a bounce buffer and move the data a piece at a time between the > + * bounce buffer and the actual transfer buffer. > + */ > len = min((unsigned int) sectors, (unsigned int) info->blocksize >> > info->smallpageshift) * PAGESIZE; > buffer = kmalloc(len, GFP_NOIO); > @@ -336,10 +336,10 @@ static int sddr55_write_data(struct us_data *us, > return USB_STOR_TRANSPORT_FAILED; > } > > - // Since we only write one block at a time, we have to create > - // a bounce buffer and move the data a piece at a time between the > - // bounce buffer and the actual transfer buffer. > - > + /* Since we only write one block at a time, we have to create > + * a bounce buffer and move the data a piece at a time between the > + * bounce buffer and the actual transfer buffer. > + */ > len = min((unsigned int) sectors, (unsigned int) info->blocksize >> > info->smallpageshift) * PAGESIZE; > buffer = kmalloc(len, GFP_NOIO); Why did you fix just these two sites? There are lots of other places in usb-storage that use C99-style comments: $ cd drivers/usb/storage $ egrep '[^:]//' *.[ch] | wc 177 1635 9562 (The [^:] is to avoid matching things like "http://", and as a result this misses the four places where a // comment starts at the beginning of a line.) Why not fix all of them? Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/