Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753172AbbFZOSe (ORCPT ); Fri, 26 Jun 2015 10:18:34 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:58350 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753090AbbFZOST (ORCPT ); Fri, 26 Jun 2015 10:18:19 -0400 Date: Fri, 26 Jun 2015 16:12:17 +0200 From: Andrew Lunn To: Vivien Didelot Cc: netdev@vger.kernel.org, "David S. Miller" , Florian Fainelli , Guenter Roeck , linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com Subject: Re: [PATCH 3/3] net: dsa: mv88e6352: add support for port_vlan_dump Message-ID: <20150626141217.GD9469@lunn.ch> References: <1435095970-18576-1-git-send-email-vivien.didelot@savoirfairelinux.com> <1435095970-18576-4-git-send-email-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1435095970-18576-4-git-send-email-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1198 Lines: 31 On Tue, Jun 23, 2015 at 05:46:10PM -0400, Vivien Didelot wrote: > Add support for dumping the VLAN Table Unit entries by pointing to the > port_vlan_dump function implemented for mv88e6xxx. > > Signed-off-by: Vivien Didelot > --- > drivers/net/dsa/mv88e6352.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/dsa/mv88e6352.c b/drivers/net/dsa/mv88e6352.c > index b524bd3..c35f57f 100644 > --- a/drivers/net/dsa/mv88e6352.c > +++ b/drivers/net/dsa/mv88e6352.c > @@ -397,6 +397,7 @@ struct dsa_switch_driver mv88e6352_switch_driver = { > .fdb_add = mv88e6xxx_port_fdb_add, > .fdb_del = mv88e6xxx_port_fdb_del, > .fdb_getnext = mv88e6xxx_port_fdb_getnext, > + .port_vlan_dump = mv88e6xxx_port_vlan_dump, > }; Once the code is made generic in terms of number of ports, i would suggest adding this to all drivers which support it. Between us, we can test most of them. Thanks Andrew -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/