Message-ID: <1435331786.9377.56.camel@perches.com>
Subject: Re: [PATCH 3/4] staging: wilc1000: remove whitespaces before quoted
 newlines
From: Joe Perches <joe@perches.com>
To: Luis de Bethencourt <luis@debethencourt.com>
Cc: linux-kernel@vger.kernel.org, Johnny Kim <johnny.kim@atmel.com>,
        Rachel Kim <rachel.kim@atmel.com>, Dean Lee <dean.lee@atmel.com>,
        Chris Park <chris.park@atmel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org
Date: Fri, 26 Jun 2015 08:16:26 -0700
In-Reply-To: <20150626151141.GA31177@goodgumbo.baconseed.org>
References: <20150626144555.GA30031@goodgumbo.baconseed.org>
	 <1435330172.9377.52.camel@perches.com>
	 <20150626151141.GA31177@goodgumbo.baconseed.org>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1821
Lines: 45

On Fri, 2015-06-26 at 17:11 +0200, Luis de Bethencourt wrote:
> On Fri, Jun 26, 2015 at 07:49:32AM -0700, Joe Perches wrote:
> > On Fri, 2015-06-26 at 16:45 +0200, Luis de Bethencourt wrote:
> > > Fix all checkpatch.pl warnings:
> > > WARNING: unnecessary whitespace before a quoted newline
> > 
> > Unassociated but:
> > 
> > > diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
> > []
> > > @@ -740,7 +740,7 @@ s32 Handle_set_IPAddress(void *drvHandler, u8 *pu8IPAddr, u8 idx)
> > >  	if (pu8IPAddr[0] < 192)
> > >  		pu8IPAddr[0] = 0;
> > >  
> > > -	PRINT_INFO(HOSTINF_DBG, "Indx = %d, Handling set  IP = %d.%d.%d.%d \n", idx, pu8IPAddr[0], pu8IPAddr[1], pu8IPAddr[2], pu8IPAddr[3]);
> > > +	PRINT_INFO(HOSTINF_DBG, "Indx = %d, Handling set  IP = %d.%d.%d.%d\n", idx, pu8IPAddr[0], pu8IPAddr[1], pu8IPAddr[2], pu8IPAddr[3]);
> > 
> > These printks with ip addresses could use vsprintf extension %pI4
> > 
> > 	PRINT_INFO(HOSTINF_DBG, "Indx = %d, Handling set  IP = %pI4\n",
> > 		   idx, pu8IPAddr);
> > 
> > 
> 
> Hi Joe,

Hello Luis.

> I could send this as a 5th patch in the series if you'd like, and set you as
> author.

Sure, but if you're doing it, you are the author.
You could use a "Suggested-by" tag, but I don't care.

> -   PRINT_INFO(HOSTINF_DBG, "Indx = %d, Handling set  IP = %d.%d.%d.%d\n", idx, pu8IPAddr[0], pu8IPAddr[1], pu8    IPAddr[2], pu8IPAddr[3]);
> +   PRINT_INFO(HOSTINF_DBG, "Indx = %d, Handling set  IP = %pI4\n", idx, pu8IPAddr);

There are 3 sites in host_interface that could be changed.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/