Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752613AbbFZQF7 (ORCPT ); Fri, 26 Jun 2015 12:05:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35115 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751746AbbFZQFv (ORCPT ); Fri, 26 Jun 2015 12:05:51 -0400 Date: Fri, 26 Jun 2015 12:05:50 -0400 From: Mike Snitzer To: Geert Uytterhoeven Cc: Joe Thornber , linux-raid@vger.kernel.org, Linux Kernel Mailing List , dm-devel@redhat.com Subject: Re: DM_CACHE_SMQ is experimental and enabled by default? (was: Re: dm cache: add stochastic-multi-queue (smq) policy) Message-ID: <20150626160549.GA15434@redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1895 Lines: 52 On Fri, Jun 26 2015 at 3:47am -0400, Geert Uytterhoeven wrote: > On Fri, Jun 26, 2015 at 2:13 AM, Linux Kernel Mailing List > wrote: > > Gitweb: http://git.kernel.org/linus/;a=commit;h=66a636356647a9be8885c2ce2948de126577698a > > Commit: 66a636356647a9be8885c2ce2948de126577698a > > Parent: 40775257b97e27305cf5c2425be7acaa6edee4ea > > Refname: refs/heads/master > > Author: Joe Thornber > > AuthorDate: Fri May 15 15:33:34 2015 +0100 > > Committer: Mike Snitzer > > CommitDate: Thu Jun 11 17:12:59 2015 -0400 > > > > dm cache: add stochastic-multi-queue (smq) policy > > > diff --git a/drivers/md/Kconfig b/drivers/md/Kconfig > > index edcf4ab..b597273 100644 > > --- a/drivers/md/Kconfig > > +++ b/drivers/md/Kconfig > > @@ -304,6 +304,18 @@ config DM_CACHE_MQ > > This is meant to be a general purpose policy. It prioritises > > reads over writes. > > > > +config DM_CACHE_SMQ > > + tristate "Stochastic MQ Cache Policy (EXPERIMENTAL)" > > + depends on DM_CACHE > > + default y > > A feature cannot be "EXPERIMENTAL", and be enabled by default. > Please drop (at least) one of them. Thanks for your concern, but: no. If you look closer the entirety of DM cache is marked EXPERIMENTAL: config DM_CACHE tristate "Cache target (EXPERIMENTAL)" ... config DM_CACHE_MQ tristate "MQ Cache Policy (EXPERIMENTAL)" ... config DM_CACHE_SMQ tristate "Stochastic MQ Cache Policy (EXPERIMENTAL)" ... config DM_CACHE_CLEANER tristate "Cleaner Cache Policy (EXPERIMENTAL)" -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/