Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752146AbbFZQOL (ORCPT ); Fri, 26 Jun 2015 12:14:11 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:35602 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751633AbbFZQOD (ORCPT ); Fri, 26 Jun 2015 12:14:03 -0400 Date: Fri, 26 Jun 2015 18:20:07 +0200 From: Luis de Bethencourt To: Dan Carpenter Cc: Sunil Shahu , gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, sudipm.mukherjee@gmail.com Subject: Re: [PATCH] staging: rtl8712: rtl871x_security.c: remove unnecessary variable initialization Message-ID: <20150626162003.GA1999@goodgumbo.baconseed.org> References: <1435327944-7425-1-git-send-email-shshahu@gmail.com> <20150626155025.GA463@goodgumbo.baconseed.org> <20150626155133.GW30834@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150626155133.GW30834@mwanda> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1982 Lines: 56 On Fri, Jun 26, 2015 at 06:51:33PM +0300, Dan Carpenter wrote: > On Fri, Jun 26, 2015 at 05:50:27PM +0200, Luis de Bethencourt wrote: > > On Fri, Jun 26, 2015 at 07:42:24PM +0530, Sunil Shahu wrote: > > > Variable "u32 c" always re-initialize in for loop. > > > Initialized value of "u32 c" is not used in function > > > and is redundant, hence removed. > > > > > > Suggested-by: Dan Carpenter > > > Signed-off-by: Sunil Shahu > > > --- > > > drivers/staging/rtl8712/rtl871x_security.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/staging/rtl8712/rtl871x_security.c b/drivers/staging/rtl8712/rtl871x_security.c > > > index 21465c9..8627928 100644 > > > --- a/drivers/staging/rtl8712/rtl871x_security.c > > > +++ b/drivers/staging/rtl8712/rtl871x_security.c > > > @@ -125,7 +125,7 @@ static u8 crc32_reverseBit(u8 data) > > > static void crc32_init(void) > > > { > > > sint i, j; > > > - u32 c = 0x12340000; > > > + u32 c; > > > u8 *p = (u8 *)&c, *p1; > > > u8 k; > > > > > > -- > > > 1.9.1 > > > > The patch is good, the value assigned to c is immediately overwritten. > > > > Unfortunately the patch fails to apply in staging-testing and linux-next. Could > > you please rebase? > > It's based on earlier patches on the list. > > Normally only Greg tests that patches apply and it will for him because > he applies them as the order they arrive. But we should probably start > putting notes on the patches which earlier patches are required... > > regards, > dan carpenter > I see. Thanks for the explanation. Then the patch is good, but it doesn't need a Reviewed-by line since it you pre-approved it. Regards, Luis -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/