Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752489AbbFZTY3 (ORCPT ); Fri, 26 Jun 2015 15:24:29 -0400 Received: from mail-la0-f45.google.com ([209.85.215.45]:33872 "EHLO mail-la0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752570AbbFZTYX (ORCPT ); Fri, 26 Jun 2015 15:24:23 -0400 From: Tom Gundersen To: linux-usb@vger.kernel.org Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Tom Gundersen , Jiri Kosina , Greg Kroah-Hartman Subject: [PATCH][RFC] usbhid: enable autosuspend for internal devices Date: Fri, 26 Jun 2015 21:24:07 +0200 Message-Id: <1435346647-29473-1-git-send-email-teg@jklm.no> X-Mailer: git-send-email 2.4.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1499 Lines: 47 This policy used to be unconditionally applied by udev, but there is no reason to make userspace be involved in this and in the future udev will not be doing it by default. See: . Signed-off-by: Tom Gundersen Cc: Jiri Kosina Cc: Greg Kroah-Hartman --- Hi, I don't have the right hardware for this, so it has only been compile-tested. I'm therefore sending it as an RFC only. Mainly I want to bring it to people's attention that it would be great to get this feature into the kernel as we want to drop it from udev. Cheers, Tom drivers/hid/usbhid/hid-core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c index bfbe1be..af80700 100644 --- a/drivers/hid/usbhid/hid-core.c +++ b/drivers/hid/usbhid/hid-core.c @@ -1358,6 +1358,9 @@ static int usbhid_probe(struct usb_interface *intf, const struct usb_device_id * setup_timer(&usbhid->io_retry, hid_retry_timeout, (unsigned long) hid); spin_lock_init(&usbhid->lock); + if (dev->removable == USB_DEVICE_FIXED) + usb_enable_autosuspend(dev); + ret = hid_add_device(hid); if (ret) { if (ret != -ENODEV) -- 2.4.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/