Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752987AbbFZT5o (ORCPT ); Fri, 26 Jun 2015 15:57:44 -0400 Received: from e19.ny.us.ibm.com ([129.33.205.209]:57567 "EHLO e19.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752899AbbFZT5h (ORCPT ); Fri, 26 Jun 2015 15:57:37 -0400 X-Helo: d01dlp03.pok.ibm.com X-MailFrom: guptav@linux.vnet.ibm.com X-RcptTo: linux-kernel@vger.kernel.org Subject: [PATCH] staging:slicoss:slicoss.h remove volatile variables To: Greg Kroah-Hartman References: <558DA29F.3020404@linux.vnet.ibm.com> <20150626191057.GA20142@kroah.com> Cc: "Cc: Lior Dotan" , Christopher Harrer , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Vikul Gupta Message-ID: <558DAEAC.3000800@linux.vnet.ibm.com> Date: Fri, 26 Jun 2015 12:57:32 -0700 User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <20150626191057.GA20142@kroah.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15062619-0057-0000-0000-00000090C088 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1584 Lines: 39 I am a high school student trying to become familiar with the opensource process and linux kernel. This is my first submission to the mailing list. I fixed the slicoss sub-system. The TODO file asks to remove volatile variables - also, checkpatch.pl warnings included volatile variables. I removed "volatile" from the variables /isr /and /linkstatus/ in the header file, because they are not needed. The two variables are used in the slicoss.c file, where /isr/ is used as function parameters, string outputs, pointers, logic, and one assignment, while /linkstatus /is used as pointers, logic, and one assignment. All but the assignments will not change these variables, and the assignment does not warrant a volatile qualifier. To make sure the changes were correct, I ran the files with checkpatch.pl again, test built it, and rebooted it. Signed-off-by: Vikul Gupta diff --git a/drivers/staging/slicoss/slic.h b/drivers/staging/slicoss/slic.h index 3a5aa88..f19f86a 100644 --- a/drivers/staging/slicoss/slic.h +++ b/drivers/staging/slicoss/slic.h @@ -357,8 +357,8 @@ struct base_driver { }; struct slic_shmem { - volatile u32 isr; - volatile u32 linkstatus; + u32 isr; + u32 linkstatus; volatile struct slic_stats inicstats; }; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/