Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751954AbbFZVek (ORCPT ); Fri, 26 Jun 2015 17:34:40 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:42697 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751969AbbFZVeb (ORCPT ); Fri, 26 Jun 2015 17:34:31 -0400 Message-ID: <558DC55D.3000804@oracle.com> Date: Fri, 26 Jun 2015 17:34:21 -0400 From: Sasha Levin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: linux-mm@kvack.org CC: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, kirill@shutemov.name Subject: Re: [PATCH 00/11] mm: debug: formatting memory management structs References: <1431623414-1905-1-git-send-email-sasha.levin@oracle.com> In-Reply-To: <1431623414-1905-1-git-send-email-sasha.levin@oracle.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4533 Lines: 103 There were no objections beyond Andrew's request for a better changelog. If there are no any further objections, can it be merged please? On 05/14/2015 01:10 PM, Sasha Levin wrote: > This patch series adds knowledge about various memory management structures > to the standard print functions. > > In essence, it allows us to easily print those structures: > > printk("%pZp %pZm %pZv", page, mm, vma); > > This allows us to customize output when hitting bugs even further, thus > we introduce VM_BUG() which allows printing anything when hitting a bug > rather than just a single piece of information. > > This also means we can get rid of VM_BUG_ON_* since they're now nothing > more than a format string. > > Changes since RFC: > - Address comments by Kirill. > > Sasha Levin (11): > mm: debug: format flags in a buffer > mm: debug: deal with a new family of MM pointers > mm: debug: dump VMA into a string rather than directly on screen > mm: debug: dump struct MM into a string rather than directly on > screen > mm: debug: dump page into a string rather than directly on screen > mm: debug: clean unused code > mm: debug: VM_BUG() > mm: debug: kill VM_BUG_ON_PAGE > mm: debug: kill VM_BUG_ON_VMA > mm: debug: kill VM_BUG_ON_MM > mm: debug: use VM_BUG() to help with debug output > > arch/arm/mm/mmap.c | 2 +- > arch/frv/mm/elf-fdpic.c | 4 +- > arch/mips/mm/gup.c | 4 +- > arch/parisc/kernel/sys_parisc.c | 2 +- > arch/powerpc/mm/hugetlbpage.c | 2 +- > arch/powerpc/mm/pgtable_64.c | 4 +- > arch/s390/mm/gup.c | 2 +- > arch/s390/mm/mmap.c | 2 +- > arch/s390/mm/pgtable.c | 6 +-- > arch/sh/mm/mmap.c | 2 +- > arch/sparc/kernel/sys_sparc_64.c | 4 +- > arch/sparc/mm/gup.c | 2 +- > arch/sparc/mm/hugetlbpage.c | 4 +- > arch/tile/mm/hugetlbpage.c | 2 +- > arch/x86/kernel/sys_x86_64.c | 2 +- > arch/x86/mm/gup.c | 8 ++-- > arch/x86/mm/hugetlbpage.c | 2 +- > arch/x86/mm/pgtable.c | 6 +-- > include/linux/huge_mm.h | 2 +- > include/linux/hugetlb.h | 2 +- > include/linux/hugetlb_cgroup.h | 4 +- > include/linux/mm.h | 22 ++++----- > include/linux/mmdebug.h | 40 ++++++---------- > include/linux/page-flags.h | 26 +++++----- > include/linux/pagemap.h | 11 +++-- > include/linux/rmap.h | 2 +- > kernel/fork.c | 2 +- > lib/vsprintf.c | 22 +++++++++ > mm/balloon_compaction.c | 4 +- > mm/cleancache.c | 6 +-- > mm/compaction.c | 2 +- > mm/debug.c | 98 ++++++++++++++++++++------------------ > mm/filemap.c | 18 +++---- > mm/gup.c | 12 ++--- > mm/huge_memory.c | 50 +++++++++---------- > mm/hugetlb.c | 28 +++++------ > mm/hugetlb_cgroup.c | 2 +- > mm/internal.h | 8 ++-- > mm/interval_tree.c | 2 +- > mm/kasan/report.c | 2 +- > mm/ksm.c | 13 ++--- > mm/memcontrol.c | 48 +++++++++---------- > mm/memory.c | 10 ++-- > mm/memory_hotplug.c | 2 +- > mm/migrate.c | 6 +-- > mm/mlock.c | 4 +- > mm/mmap.c | 15 +++--- > mm/mremap.c | 4 +- > mm/page_alloc.c | 28 +++++------ > mm/page_io.c | 4 +- > mm/pagewalk.c | 2 +- > mm/pgtable-generic.c | 8 ++-- > mm/rmap.c | 20 ++++---- > mm/shmem.c | 10 ++-- > mm/slub.c | 4 +- > mm/swap.c | 39 +++++++-------- > mm/swap_state.c | 16 +++---- > mm/swapfile.c | 8 ++-- > mm/vmscan.c | 24 +++++----- > 59 files changed, 355 insertions(+), 335 deletions(-) > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/