Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752733AbbFZVrb (ORCPT ); Fri, 26 Jun 2015 17:47:31 -0400 Received: from mail-pa0-f41.google.com ([209.85.220.41]:33309 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752466AbbFZVrW (ORCPT ); Fri, 26 Jun 2015 17:47:22 -0400 From: bjorn@kryo.se X-Google-Original-From: bjorn.andersson@sonymobile.com To: Andy Gross , Ohad Ben-Cohen Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH] hwspinlock: qcom: Correct msb in regmap_field Date: Fri, 26 Jun 2015 14:47:21 -0700 Message-Id: <1435355241-23511-1-git-send-email-bjorn.andersson@sonymobile.com> X-Mailer: git-send-email 1.9.3 (Apple Git-50) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1196 Lines: 32 From: Bjorn Andersson msb of the regmap_field was mistakenly given the value 32, to set all bits in the regmap update mask; although incorrect this worked until 921cc294, where the mask calculation was corrected. Signed-off-by: Bjorn Andersson --- drivers/hwspinlock/qcom_hwspinlock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwspinlock/qcom_hwspinlock.c b/drivers/hwspinlock/qcom_hwspinlock.c index 93b62e0..c752447 100644 --- a/drivers/hwspinlock/qcom_hwspinlock.c +++ b/drivers/hwspinlock/qcom_hwspinlock.c @@ -123,7 +123,7 @@ static int qcom_hwspinlock_probe(struct platform_device *pdev) for (i = 0; i < QCOM_MUTEX_NUM_LOCKS; i++) { field.reg = base + i * stride; field.lsb = 0; - field.msb = 32; + field.msb = 31; bank->lock[i].priv = devm_regmap_field_alloc(&pdev->dev, regmap, field); -- 1.9.3 (Apple Git-50) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/