Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752940AbbF0Gix (ORCPT ); Sat, 27 Jun 2015 02:38:53 -0400 Received: from mail-oi0-f46.google.com ([209.85.218.46]:33131 "EHLO mail-oi0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751735AbbF0Giq (ORCPT ); Sat, 27 Jun 2015 02:38:46 -0400 MIME-Version: 1.0 In-Reply-To: <558D51D4.9060202@cogentembedded.com> References: <1435320502-4951-1-git-send-email-geert@linux-m68k.org> <558D51D4.9060202@cogentembedded.com> Date: Sat, 27 Jun 2015 14:38:45 +0800 Message-ID: Subject: Re: [PATCH] net: via: VIA_RHINE and VIA_VELOCITY should depend on HAS_DMA From: Antonio Borneo To: Sergei Shtylyov Cc: Geert Uytterhoeven , "David S. Miller" , netdev@vger.kernel.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2090 Lines: 64 On Fri, Jun 26, 2015 at 9:21 PM, Sergei Shtylyov wrote: > Hello. > > On 6/26/2015 3:08 PM, Geert Uytterhoeven wrote: > >> If NO_DMA=y: > > >> ERROR: "dma_sync_single_for_cpu" >> [drivers/net/ethernet/via/via-rhine.ko] undefined! >> ERROR: "dma_set_mask" [drivers/net/ethernet/via/via-rhine.ko] >> undefined! >> ERROR: "dma_mapping_error" [drivers/net/ethernet/via/via-rhine.ko] >> undefined! >> ERROR: "dma_map_single" [drivers/net/ethernet/via/via-rhine.ko] >> undefined! >> ERROR: "dma_alloc_coherent" [drivers/net/ethernet/via/via-rhine.ko] >> undefined! >> ERROR: "dma_free_coherent" [drivers/net/ethernet/via/via-rhine.ko] >> undefined! >> ERROR: "dma_unmap_single" [drivers/net/ethernet/via/via-rhine.ko] >> undefined! >> ERROR: "dma_map_page" [drivers/net/ethernet/via/via-velocity.ko] >> undefined! >> ERROR: "dma_sync_single_for_cpu" >> [drivers/net/ethernet/via/via-velocity.ko] undefined! >> ERROR: "dma_free_coherent" [drivers/net/ethernet/via/via-velocity.ko] >> undefined! >> ERROR: "dma_unmap_single" [drivers/net/ethernet/via/via-velocity.ko] >> undefined! >> ERROR: "dma_map_single" [drivers/net/ethernet/via/via-velocity.ko] >> undefined! >> ERROR: "dma_alloc_coherent" >> [drivers/net/ethernet/via/via-velocity.ko] undefined! > > >> Before, the symbols depended implicitly on HAS_DMA through PCI or >> USE_OF. Add explicit dependencies on HAS_DMA to fix this. > > >> Fixes: commit b7d3282a245f4428 ("net: via/Kconfig: replace USE_OF with >> OF_???") > > > Fixes: b7d3282a245f ("net: via/Kconfig: replace USE_OF with OF_???") > >> Signed-off-by: Geert Uytterhoeven > > > WBR, Sergei > Yes, I can confirm it. If HAS_DMA is not defined the build is broken. Your patch fixes the issue. Thanks, Antonio -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/