Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752630AbbF0GxY (ORCPT ); Sat, 27 Jun 2015 02:53:24 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:51272 "EHLO mx08-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751672AbbF0GxR (ORCPT ); Sat, 27 Jun 2015 02:53:17 -0400 Message-ID: <558E47EC.6010504@st.com> Date: Sat, 27 Jun 2015 08:51:24 +0200 From: Maxime Coquelin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: , , , , , , , , , Subject: Re: [tip:irq/urgent] pinctrl/st: Fix race in installing chained IRQ handler References: In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.251.17.131] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151,1.0.33,0.0.0000 definitions=2015-06-27_01:2015-06-26,2015-06-27,1970-01-01 signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2639 Lines: 84 Hello Thomas, On 06/26/2015 09:45 PM, tip-bot for Thomas Gleixner wrote: > Commit-ID: 1b11b0cb799e5f82ca6391a23eaa8f41c7466cc0 > Gitweb: http://git.kernel.org/tip/1b11b0cb799e5f82ca6391a23eaa8f41c7466cc0 > Author: Thomas Gleixner > AuthorDate: Sun, 21 Jun 2015 20:16:15 +0200 > Committer: Thomas Gleixner > CommitDate: Thu, 25 Jun 2015 11:57:09 +0200 > > pinctrl/st: Fix race in installing chained IRQ handler > > Fix a race where a pending interrupt could be received and the handler > called before the handler's data has been setup, by converting to > irq_set_chained_handler_and_data(). > > Search and conversion was done with coccinelle: > > @@ > expression E1, E2, E3; > @@ > ( > -if (irq_set_chained_handler(E1, E3) != 0) > - BUG(); > | > -irq_set_chained_handler(E1, E3); > ) > -irq_set_handler_data(E1, E2); > +irq_set_chained_handler_and_data(E1, E3, E2); > > @@ > expression E1, E2, E3; > @@ > ( > -if (irq_set_chained_handler(E1, E3) != 0) > - BUG(); > ... > | > -irq_set_chained_handler(E1, E3); > ... > ) > -irq_set_handler_data(E1, E2); > +irq_set_chained_handler_and_data(E1, E3, E2); > > Reported-by: Russell King > Signed-off-by: Thomas Gleixner > Cc: Julia Lawall > Cc: Srinivas Kandagatla > Cc: Maxime Coquelin > Cc: Patrice Chotard > Cc: Linus Walleij > Cc: linux-arm-kernel@lists.infradead.org > Cc: kernel@stlinux.com > Cc: linux-gpio@vger.kernel.org > --- > drivers/pinctrl/pinctrl-st.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c > index 65bf73b..10e9c4e8 100644 > --- a/drivers/pinctrl/pinctrl-st.c > +++ b/drivers/pinctrl/pinctrl-st.c > @@ -1661,8 +1661,8 @@ static int st_pctl_probe_dt(struct platform_device *pdev, > if (IS_ERR(info->irqmux_base)) > return PTR_ERR(info->irqmux_base); > > - irq_set_chained_handler(irq, st_gpio_irqmux_handler); > - irq_set_handler_data(irq, info); > + irq_set_chained_handler_and_data(irq, st_gpio_irqmux_handler, > + info); > > } > I cannot test the patch before Monday, but it looks good to me: Acked-by: Maxime Coquelin Thanks! Maxime -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/