Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754126AbbF0Mr1 (ORCPT ); Sat, 27 Jun 2015 08:47:27 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:36782 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752544AbbF0MrU (ORCPT ); Sat, 27 Jun 2015 08:47:20 -0400 From: Pali =?utf-8?q?Roh=C3=A1r?= To: Gabriele Mazzotta Subject: Re: [PATCH v3 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k Date: Sat, 27 Jun 2015 14:47:16 +0200 User-Agent: KMail/1.13.7 (Linux/3.13.0-55-generic; KDE/4.14.2; x86_64; ; ) Cc: "Greg Kroah-Hartman" , Guenter Roeck , Arnd Bergmann , Jean Delvare , Steven Honeyman , Valdis.Kletnieks@vt.edu, Jochen Eisinger , linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org References: <20150428123850.GA8855@kroah.com> <1430307686-1734-2-git-send-email-pali.rohar@gmail.com> <3228158.O80YglnvCi@xps13> In-Reply-To: <3228158.O80YglnvCi@xps13> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart4409248.3PGDtQR7TW"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201506271447.16248@pali> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1834 Lines: 59 --nextPart4409248.3PGDtQR7TW Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Saturday 27 June 2015 13:34:30 Gabriele Mazzotta wrote: > Hi Pali, >=20 > I've just noticed an issue with this patch. See the comment here > below. >=20 > Gabriele >=20 > On Wednesday 29 April 2015 13:41:26 Pali Roh=C3=A1r wrote: > > @@ -750,8 +777,8 @@ static int __init i8k_init_hwmon(void) > >=20 > > if (err >=3D 0) > > =09 > > i8k_hwmon_flags |=3D I8K_HWMON_HAVE_FAN2; > >=20 > > - i8k_hwmon_dev =3D hwmon_device_register_with_groups(NULL, "i8k", > > NULL, - i8k_groups); > > + i8k_hwmon_dev =3D hwmon_device_register_with_groups(NULL, > > "dell-smm", + NULL, i8k_groups); >=20 > dell-smm is not a valid name, see hwmon_device_register_with_groups() > for more info (dash not allowed). Because of this, the driver can't > be loaded. >=20 How it is possible? It worked fine on my tested dell machine... And now I see, I probably tested this change with older kernel version=20 (ubuntu/3.13) which did not have that check for invalid characters... Renaming dell-smm to dell_smm should fix this problem, right? =2D-=20 Pali Roh=C3=A1r pali.rohar@gmail.com --nextPart4409248.3PGDtQR7TW Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAlWOm1QACgkQi/DJPQPkQ1I1zgCfWdg70G5h5vjbQ5IfqOCz2LNx nj8AmwXy6f8yeFYnShZE9sW2QAljucVM =34qb -----END PGP SIGNATURE----- --nextPart4409248.3PGDtQR7TW-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/