Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753248AbbF0NWO (ORCPT ); Sat, 27 Jun 2015 09:22:14 -0400 Received: from mail-wg0-f52.google.com ([74.125.82.52]:35536 "EHLO mail-wg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753284AbbF0NVz convert rfc822-to-8bit (ORCPT ); Sat, 27 Jun 2015 09:21:55 -0400 From: Gabriele Mazzotta To: Pali =?ISO-8859-1?Q?Roh=E1r?= Cc: Greg Kroah-Hartman , Guenter Roeck , Arnd Bergmann , Jean Delvare , Steven Honeyman , Valdis.Kletnieks@vt.edu, Jochen Eisinger , linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org Subject: Re: [PATCH v3 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k Date: Sat, 27 Jun 2015 15:21:47 +0200 Message-ID: <4187402.aaVDYOIDya@xps13> In-Reply-To: <201506271501.34645@pali> References: <20150428123850.GA8855@kroah.com> <5861345.suUcko3aRb@xps13> <201506271501.34645@pali> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1742 Lines: 45 On Saturday 27 June 2015 15:01:34 Pali Roh?r wrote: > On Saturday 27 June 2015 14:55:40 Gabriele Mazzotta wrote: > > On Saturday 27 June 2015 14:47:16 Pali Roh?r wrote: > > > On Saturday 27 June 2015 13:34:30 Gabriele Mazzotta wrote: > > > > Hi Pali, > > > > > > > > I've just noticed an issue with this patch. See the comment here > > > > below. > > > > > > > > Gabriele > > > > > > > > On Wednesday 29 April 2015 13:41:26 Pali Roh?r wrote: > > > > > @@ -750,8 +777,8 @@ static int __init i8k_init_hwmon(void) > > > > > > > > > > if (err >= 0) > > > > > > > > > > i8k_hwmon_flags |= I8K_HWMON_HAVE_FAN2; > > > > > > > > > > - i8k_hwmon_dev = hwmon_device_register_with_groups(NULL, > > > > > "i8k", NULL, - i8k_groups); > > > > > + i8k_hwmon_dev = hwmon_device_register_with_groups(NULL, > > > > > "dell-smm", + NULL, i8k_groups); > > > > > > > > dell-smm is not a valid name, see > > > > hwmon_device_register_with_groups() for more info (dash not > > > > allowed). Because of this, the driver can't be loaded. > > > > > > How it is possible? It worked fine on my tested dell machine... > > > > > > And now I see, I probably tested this change with older kernel > > > version (ubuntu/3.13) which did not have that check for invalid > > > characters... > > > > > > Renaming dell-smm to dell_smm should fix this problem, right? > > > > Yes, everything works just fine with the underscore. > > Ok, will you send patch for this small fix? OK, I'll do it shortly. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/