Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752894AbbF0P3U (ORCPT ); Sat, 27 Jun 2015 11:29:20 -0400 Received: from mout.web.de ([212.227.15.3]:58788 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751217AbbF0P3M (ORCPT ); Sat, 27 Jun 2015 11:29:12 -0400 Message-ID: <558EC13A.30709@users.sourceforge.net> Date: Sat, 27 Jun 2015 17:28:58 +0200 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: "H. Peter Anvin" , Ingo Molnar , Muli Ben-Yehuda , Thomas Gleixner , x86@kernel.org, discuss@x86-64.org CC: Jon Mason , LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH 1/1] x86: PCI-Calgary: Deletion of an unnecessary check before the function call "free_tce_table" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <54707ADB.30807@users.sourceforge.net> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:p/HT8k+Iqh+9UaEH++Bko2g7WtZ8gyP7CDDO+u5xxvGTZjvwzGV /Wim9EbA6G4cC0zz8SHD3LrDEH9I04ba5spw2rngArTHm4C8aP6LH9dWN4UjbIR/1kh5kPc YQhVV1m468TtjfBCC6CkU0VLc3ShXk+O4PMUNBhG6k0lzgr+h3A4Ri0EjIsh4jPL/mLX9TN 8iCqYoq35fwHFovJsnEdQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:MnrKjiQMGDE=:33vpIAOa/vQSQoC8yX+N2O awBtflJd5nC+sTOINhRSkEyTAoAtACpmTwO5WTcPvYhXjttyxFhQayFzL3cBqdEBhe2Y1/f1a uUT+gMr9t2RXzCHaZ7esKF+PI/0Sfjdy5advEaKb3IKRbN8gsd97bh6qAtqdcnXCm6nddAgQ5 sEXkG+0bNf3hNzIGPDfgRJWes2CWVrhqCXmSHVLQ/l6EFhZ2HHd+fJZTa4I+4yb6Dp+9a5qSg k7LuzmfLAAtBttmPVeiZG0gTCs6hjyx6vGAXJ9OTidScmKzHB6bVHuhbZDdZmP+gCR5HFzZoP /oF4zxyNtrbKRwu6Q+Mlw4LZFkZr9liwLlwUIQWrwAATYU9z4P84BVRN8cQI5zETotDM1OQ1D A4G8g2oBzGBFzIWDw4QXzT5kQ0inOHbWxnFWKsV19tcc0IO7Hzm1DGxiP0JHGDkA337BbhGy+ POmE4A/4Kr7LqnydUUTUWosawnnhU2CwhzXQsTD38hOga5afSeBkFJfXYpHHppOABUf2LO/A2 3jCQUTFfTTI8zd9Xd7hNq4jsZQ9gIfKLRpsjcfwaKD2APan0gvJhnDk0PG/rtPWWfRTdM/alH FRNEz0Eq417/79c92B0ZCT0C2XQL8rvElSjiNAcx5GZwF4f6XXWZfdOCDPNyrR3IulwmeFx/e 4zGl5Hq2aXURhAFr8YrPTQRoQY3hS5UTyg9jIpI03shgjRpgQ6tuT8ng6lgZUz0/eFs0= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1479 Lines: 47 >> From: Markus Elfring >> Date: Sat, 22 Nov 2014 12:55:28 +0100 >> >> The free_tce_table() function tests whether its argument is NULL and then >> returns immediately. Thus the test around the call is not needed. >> >> This issue was detected by using the Coccinelle software. >> >> Signed-off-by: Markus Elfring > > Looks good to me > > Acked-by: Jon Mason > > >> --- >> arch/x86/kernel/pci-calgary_64.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/arch/x86/kernel/pci-calgary_64.c b/arch/x86/kernel/pci-calgary_64.c >> index 0497f71..d22a386 100644 >> --- a/arch/x86/kernel/pci-calgary_64.c >> +++ b/arch/x86/kernel/pci-calgary_64.c >> @@ -1476,8 +1476,7 @@ cleanup: >> for (--bus; bus >= 0; --bus) { >> struct calgary_bus_info *info = &bus_info[bus]; >> >> - if (info->tce_space) >> - free_tce_table(info->tce_space); >> + free_tce_table(info->tce_space); >> } >> return -ENOMEM; >> } >> -- >> 2.1.3 >> Do the chances increase to integrate this update suggestion into another source code repository? Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/