Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755217AbbF0Ptk (ORCPT ); Sat, 27 Jun 2015 11:49:40 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:35527 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753142AbbF0PtY (ORCPT ); Sat, 27 Jun 2015 11:49:24 -0400 Message-ID: <558EC5FE.5080007@roeck-us.net> Date: Sat, 27 Jun 2015 08:49:18 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Peter Hung , jdelvare@suse.de CC: lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org, tom_tsai@fintek.com.tw, peter_hong@fintek.com.tw, Peter Hung Subject: Re: [PATCH 1/3] hwmon:f71882fg add f81866/f71868 SuperIO support References: <1435217418-26249-1-git-send-email-hpeter+linux_kernel@gmail.com> <1435217418-26249-2-git-send-email-hpeter+linux_kernel@gmail.com> In-Reply-To: <1435217418-26249-2-git-send-email-hpeter+linux_kernel@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1982 Lines: 63 Hi Peter, On 06/25/2015 12:30 AM, Peter Hung wrote: > Add New Fintek SuperIO F81866(0x1010) & F71868(0x1106) > with H/W Monitor functions. > > Signed-off-by: Peter Hung > --- > drivers/hwmon/f71882fg.c | 50 ++++++++++++++++++++++++++++++++++-------------- > 1 file changed, 36 insertions(+), 14 deletions(-) > > diff --git a/drivers/hwmon/f71882fg.c b/drivers/hwmon/f71882fg.c > index 2e5c6f4..10bc8b3 100644 > --- a/drivers/hwmon/f71882fg.c > +++ b/drivers/hwmon/f71882fg.c > @@ -59,6 +59,8 @@ > #define SIO_F71889A_ID 0x1005 /* Chipset ID */ > #define SIO_F8000_ID 0x0581 /* Chipset ID */ > #define SIO_F81865_ID 0x0704 /* Chipset ID */ > +#define SIO_F81866_ID 0x1010 /* Chipset ID */ > +#define SIO_F71868_ID 0x1106 /* Chipset ID */ > > #define REGION_LENGTH 8 > #define ADDR_REG_OFFSET 5 > @@ -101,7 +103,7 @@ > > #define F71882FG_REG_START 0x01 > > -#define F71882FG_MAX_INS 9 > +#define F71882FG_MAX_INS 10 > > #define FAN_MIN_DETECT 366 /* Lowest detectable fanspeed */ > > @@ -110,7 +112,7 @@ module_param(force_id, ushort, 0); > MODULE_PARM_DESC(force_id, "Override the detected device ID"); > > enum chips { f71808e, f71808a, f71858fg, f71862fg, f71869, f71869a, f71882fg, > - f71889fg, f71889ed, f71889a, f8000, f81865f }; > + f71889fg, f71889ed, f71889a, f8000, f81865f, f81866a, f71868a }; > Unless there is a special reason to not do so, please keep the chip IDs in numeric order. > static const char *const f71882fg_names[] = { > "f71808e", > @@ -125,21 +127,25 @@ static const char *const f71882fg_names[] = { > "f71889a", > "f8000", > "f81865f", > + "f81866a", > + "f71868a", Same here and everywhere else. Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/