MIME-Version: 1.0
In-Reply-To: <20150627083921.GA13074@gmail.com>
References: <1435341131-3279-1-git-send-email-prarit@redhat.com>
 <20150627083354.GA12834@gmail.com> <20150627083921.GA13074@gmail.com>
From: Andy Lutomirski <luto@amacapital.net>
Date: Sat, 27 Jun 2015 08:52:07 -0700
Message-ID: <CALCETrXpiMWwiAfbxcKTDYCewrwq-UTwLV+xXTxdOkd+B3G-OQ@mail.gmail.com>
Subject: Re: [PATCH] x86, msr: Allow read access to /dev/cpu/X/msr
To: Ingo Molnar <mingo@kernel.org>
Cc: Prarit Bhargava <prarit@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>, Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, X86 ML <x86@kernel.org>,
        Len Brown <len.brown@intel.com>,
        Dasaratharaman Chandramouli 
	<dasaratharaman.chandramouli@intel.com>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Borislav Petkov <bp@alien8.de>, Andy Lutomirski <luto@kernel.org>,
        Denys Vlasenko <dvlasenk@redhat.com>, Brian Gerst <brgerst@gmail.com>,
        Arnaldo Carvalho de Melo <acme@infradead.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1523
Lines: 40

On Sat, Jun 27, 2015 at 1:39 AM, Ingo Molnar <mingo@kernel.org> wrote:
>
> * Ingo Molnar <mingo@kernel.org> wrote:
>
>> So what's wrong with exposing them as a simplified PMU driver?
>>
>> That way we only expose the ones we want to - plus tooling can use all the rich
>> perf features that can be used around this. (sampling, counting, call chains,
>> etc.)
>
> See below code from Andy that exposes a single MSR via perf. At the core of the
> PMU driver is a single rdmsrl():
>
> +static void aperfmperf_event_start(struct perf_event *event, int flags)
> +{
> +       u64 now;
> +
> +       rdmsrl(event->hw.event_base, now);
> +       local64_set(&event->hw.prev_count, now);
> +}
>
> Now I think what we really want is to expose not a single MSR but multiple MSRs in
> a single driver, i.e. don't have one PMU driver per MSR, but have a driver that
> allows the exposure of select MSRs as counters.

I'm way ahead of you: this driver can expose *two* MSRs as counters :)

Seriously, though, it would be straightforward to make it handle a
more general list, complete with non-architectural stuff (such as the
upcoming PPERF in Skylake).

This driver only knows how to handle counters, though.  I'm not sure
whether all of the MSRs that turbostat needs are counters.

--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/