Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755206AbbF0TUs (ORCPT ); Sat, 27 Jun 2015 15:20:48 -0400 Received: from forward2l.mail.yandex.net ([84.201.143.145]:53165 "EHLO forward2l.mail.yandex.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752039AbbF0TUm convert rfc822-to-8bit (ORCPT ); Sat, 27 Jun 2015 15:20:42 -0400 Authentication-Results: smtp3h.mail.yandex.net; dkim=pass header.i=@corrigendum.ru Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes To: "Linux Kernel" , =?utf-8?Q?Toralf_F=C3=B6rster?= Subject: Re: [PATCH] x86: fix -Wsign-compare warnings in uaccess.h References: <558EF68B.7000702@gmx.de> Date: Sat, 27 Jun 2015 22:20:40 +0300 MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT From: =?utf-8?B?0KDQvtC80LDQvSDQlNC+0L3Rh9C10L3QutC+?= Message-ID: In-Reply-To: <558EF68B.7000702@gmx.de> User-Agent: Opera Mail/12.17 (Win64) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 654 Lines: 16 Toralf Förster писал в своём письме Sat, 27 Jun 2015 22:16:27 +0300: >> The casts are safe, since those conditions are only evaluated when sz >> >= 0. > > > Wouldn't in this case the condition "sz < 0" be superfluously ? No, sz can be negative. I meant that if sz < 0, then the second halves won't be evaluated (though even if they did, it wouldn't matter). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/