Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752108AbbF0XGz (ORCPT ); Sat, 27 Jun 2015 19:06:55 -0400 Received: from mail-la0-f51.google.com ([209.85.215.51]:34524 "EHLO mail-la0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751896AbbF0XGu (ORCPT ); Sat, 27 Jun 2015 19:06:50 -0400 MIME-Version: 1.0 In-Reply-To: <558F28E1.7040204@maciej.szmigiero.name> References: <558F28E1.7040204@maciej.szmigiero.name> Date: Sat, 27 Jun 2015 20:06:47 -0300 Message-ID: Subject: Re: [PATCH] ASoC: fsl_ssi: fix AC'97 mode From: Fabio Estevam To: "Maciej S. Szmigiero" Cc: "alsa-devel@alsa-project.org" , Timur Tabi , Nicolin Chen , Xiubo Li , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , "linuxppc-dev@lists.ozlabs.org" , linux-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1080 Lines: 30 Hi Maciej, On Sat, Jun 27, 2015 at 7:51 PM, Maciej S. Szmigiero wrote: > Currently the AC'97 mode in fsl_ssi driver isn't functional. Thanks for the fix. I look forward to test it on my udoo board. > This patch implements the following changes to make it work > properly: > * IPG clock have to be enabled during AC'97 CODEC > register access, > * AC'97 DAI driver struct need the same probe method as > I2S one to setup DMA params, > * AC'97 bus can support asymmetric playback/capture rates, > * Check whether setting AC'97 ops succeeded and > clean them on removal so the driver can be reloaded, > * AC'97 CODEC will be instantiated in AC'97 mode, > * Set DAI format function small fixes in AC'97 mode. It seems like a lot of changes in a single patch. Care to split it into smaller pieces? Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/