Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752272AbbF0X1N (ORCPT ); Sat, 27 Jun 2015 19:27:13 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:38938 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752119AbbF0X1H (ORCPT ); Sat, 27 Jun 2015 19:27:07 -0400 Date: Sat, 27 Jun 2015 16:27:05 -0700 From: Greg Kroah-Hartman To: Patrick Donnelly Cc: Jiri Slaby , open list Subject: Re: [PATCH 2/2] Check tcsetpgrp p is a process group. Message-ID: <20150627232705.GC6433@kroah.com> References: <1435439824-3975-1-git-send-email-batrick@batbytes.com> <1435439824-3975-2-git-send-email-batrick@batbytes.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1435439824-3975-2-git-send-email-batrick@batbytes.com> User-Agent: Mutt/1.5.23+89 (0255b37be491) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1573 Lines: 45 On Sat, Jun 27, 2015 at 05:17:03PM -0400, Patrick Donnelly wrote: > This fixes a bug where a process can set the foreground process group to its > pid even if its pid is not a valid pgrp. > > Signed-off-by: Patrick Donnelly > --- > drivers/tty/tty_io.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c > index 401d05e..c20a2fb 100644 > --- a/drivers/tty/tty_io.c > +++ b/drivers/tty/tty_io.c > @@ -2560,9 +2560,11 @@ static int tiocspgrp(struct tty_struct *tty, struct tty_struct *real_tty, pid_t > { > struct pid *pgrp; > pid_t pgrp_nr; > - int retval = tty_check_change(real_tty); > + int retval; > unsigned long flags; > > + retval = tty_check_change(real_tty); > + > if (retval == -EIO) > return -ENOTTY; > if (retval) > @@ -2580,6 +2582,10 @@ static int tiocspgrp(struct tty_struct *tty, struct tty_struct *real_tty, pid_t > retval = -ESRCH; > if (!pgrp) > goto out_unlock; > + retval = -EINVAL; > + if (!pid_task(pgrp, PIDTYPE_PGID)) { > + goto out_unlock; > + } > retval = -EPERM; > if (session_of_pgrp(pgrp) != task_session(current)) > goto out_unlock; Always run your patches though checkpatch.pl so you don't get emails telling you to fix the things that checkpatch.pl tells you to... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/