Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752201AbbF0Xpc (ORCPT ); Sat, 27 Jun 2015 19:45:32 -0400 Received: from mail-ig0-f178.google.com ([209.85.213.178]:36957 "EHLO mail-ig0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752048AbbF0Xp0 (ORCPT ); Sat, 27 Jun 2015 19:45:26 -0400 MIME-Version: 1.0 In-Reply-To: <1427757610-27882-3-git-send-email-dmitry.torokhov@gmail.com> References: <1427757610-27882-1-git-send-email-dmitry.torokhov@gmail.com> <1427757610-27882-3-git-send-email-dmitry.torokhov@gmail.com> Date: Sat, 27 Jun 2015 16:45:25 -0700 Message-ID: Subject: Re: [PATCH 2/8] driver-core: add asynchronous probing support for drivers From: Dan Williams To: Dmitry Torokhov Cc: Greg Kroah-Hartman , "Luis R . Rodriguez" , Tejun Heo , Linux Kernel Mailing List , Arjan van de Ven , Rusty Russell , Olof Johansson , Tetsuo Handa Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2427 Lines: 46 On Mon, Mar 30, 2015 at 4:20 PM, Dmitry Torokhov wrote: > Some devices take a long time when initializing, and not all drivers are > suited to initialize their devices when they are open. For example, > input drivers need to interrogate their devices in order to publish > device's capabilities before userspace will open them. When such drivers > are compiled into kernel they may stall entire kernel initialization. > > This change allows drivers request for their probe functions to be > called asynchronously during driver and device registration (manual > binding is still synchronous). Because async_schedule is used to perform > asynchronous calls module loading will still wait for the probing to > complete. > > Note that the end goal is to make the probing asynchronous by default, > so annotating drivers with PROBE_PREFER_ASYNCHRONOUS is a temporary > measure that allows us to speed up boot process while we validating and > fixing the rest of the drivers and preparing userspace. > > This change is based on earlier patch by "Luis R. Rodriguez" > > > Signed-off-by: Dmitry Torokhov > --- > drivers/base/base.h | 1 + > drivers/base/bus.c | 31 +++++++--- > drivers/base/dd.c | 149 ++++++++++++++++++++++++++++++++++++++++++------- > include/linux/device.h | 28 ++++++++++ > 4 files changed, 182 insertions(+), 27 deletions(-) Just noticed this patch. It caught my eye because I had a hard time getting an open coded implementation of asynchronous probing to work in the new libnvdimm subsystem. Especially the messy races of tearing things down while probing is still in flight. I ended up implementing asynchronous device registration which eliminated a lot of complexity and of course the bugs. In general I tend to think that async registration is less risky than async probe since it keeps wider portions of the traditional device model synchronous and leverages the fact that the device model is already well prepared for asynchronous arrival of devices due to hotplug. Splitting the "initial probe" from the "manual probe" case seems like a recipe for confusion. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/