Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752333AbbF1Av7 (ORCPT ); Sat, 27 Jun 2015 20:51:59 -0400 Received: from mail-ig0-f170.google.com ([209.85.213.170]:36559 "EHLO mail-ig0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752051AbbF1Avk (ORCPT ); Sat, 27 Jun 2015 20:51:40 -0400 From: Patrick Donnelly To: Greg Kroah-Hartman , Jiri Slaby , linux-kernel@vger.kernel.org (open list) Cc: Patrick Donnelly Subject: [PATCH v2 2/2] tty: check tcsetpgrp p is a process group Date: Sat, 27 Jun 2015 20:51:29 -0400 Message-Id: <1435452689-25390-2-git-send-email-batrick@batbytes.com> X-Mailer: git-send-email 2.4.4 In-Reply-To: <1435452689-25390-1-git-send-email-batrick@batbytes.com> References: <1435439824-3975-1-git-send-email-batrick@batbytes.com> <1435452689-25390-1-git-send-email-batrick@batbytes.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 974 Lines: 30 This fixes a bug where a process can set the foreground process group to its pid even if its pid is not a valid pgrp. Signed-off-by: Patrick Donnelly --- drivers/tty/tty_io.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c index fbb55db..01b4769 100644 --- a/drivers/tty/tty_io.c +++ b/drivers/tty/tty_io.c @@ -2579,6 +2579,9 @@ static int tiocspgrp(struct tty_struct *tty, struct tty_struct *real_tty, pid_t retval = -ESRCH; if (!pgrp) goto out_unlock; + retval = -EINVAL; + if (!pid_task(pgrp, PIDTYPE_PGID)) + goto out_unlock; retval = -EPERM; if (session_of_pgrp(pgrp) != task_session(current)) goto out_unlock; -- Patrick Donnelly -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/