Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752090AbbF1AxG (ORCPT ); Sat, 27 Jun 2015 20:53:06 -0400 Received: from mail-yk0-f173.google.com ([209.85.160.173]:34788 "EHLO mail-yk0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751824AbbF1AxE (ORCPT ); Sat, 27 Jun 2015 20:53:04 -0400 MIME-Version: 1.0 In-Reply-To: <20150627232631.GB6433@kroah.com> References: <1435439824-3975-1-git-send-email-batrick@batbytes.com> <1435439824-3975-2-git-send-email-batrick@batbytes.com> <20150627232631.GB6433@kroah.com> Date: Sat, 27 Jun 2015 20:53:03 -0400 Message-ID: Subject: Re: [PATCH 2/2] Check tcsetpgrp p is a process group. From: Patrick Donnelly To: Greg Kroah-Hartman Cc: Jiri Slaby , open list Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1278 Lines: 37 On Sat, Jun 27, 2015 at 7:26 PM, Greg Kroah-Hartman wrote: > On Sat, Jun 27, 2015 at 05:17:03PM -0400, Patrick Donnelly wrote: >> This fixes a bug where a process can set the foreground process group to its >> pid even if its pid is not a valid pgrp. >> >> Signed-off-by: Patrick Donnelly >> --- >> drivers/tty/tty_io.c | 8 +++++++- >> 1 file changed, 7 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c >> index 401d05e..c20a2fb 100644 >> --- a/drivers/tty/tty_io.c >> +++ b/drivers/tty/tty_io.c >> @@ -2560,9 +2560,11 @@ static int tiocspgrp(struct tty_struct *tty, struct tty_struct *real_tty, pid_t >> { >> struct pid *pgrp; >> pid_t pgrp_nr; >> - int retval = tty_check_change(real_tty); >> + int retval; >> unsigned long flags; >> >> + retval = tty_check_change(real_tty); > > Why this churn? I removed it in the new version, sorry. I thought it made the code more consistent. -- Patrick Donnelly -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/